Re: Review Request 116079: Be more explicit with QFile include

2014-02-26 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116079/ --- (Updated Feb. 26, 2014, 4:36 p.m.) Status -- This change has been di

Re: Review Request 116079: Be more explicit with QFile include

2014-02-26 Thread Aurélien Gâteau
> On Feb. 26, 2014, 4:36 p.m., Aurélien Gâteau wrote: > > My memory may be failing me, but I think it was actually decided to go the > > other way around for Qt5 includes: not prepending the module dir. Can > > anyone else confirm? This should be mentioned in the framework policies, I > > thin

Re: Review Request 116079: Be more explicit with QFile include

2014-02-26 Thread Alex Merry
> On Feb. 26, 2014, 3:36 p.m., Aurélien Gâteau wrote: > > My memory may be failing me, but I think it was actually decided to go the > > other way around for Qt5 includes: not prepending the module dir. Can > > anyone else confirm? This should be mentioned in the framework policies, I > > thin

Re: Review Request 116079: Be more explicit with QFile include

2014-02-26 Thread Alex Merry
> On Feb. 26, 2014, 3:36 p.m., Aurélien Gâteau wrote: > > My memory may be failing me, but I think it was actually decided to go the > > other way around for Qt5 includes: not prepending the module dir. Can > > anyone else confirm? This should be mentioned in the framework policies, I > > thin

Re: Review Request 116079: Be more explicit with QFile include

2014-02-26 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116079/#review50945 --- My memory may be failing me, but I think it was actually decid

Review Request 116079: Be more explicit with QFile include

2014-02-26 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116079/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc