Re: Review Request 116018: Add a FindWayland module

2014-02-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116018/ --- (Updated Feb. 25, 2014, 1:46 p.m.) Status -- This change has been ma

Re: Review Request 116018: Add a FindWayland module

2014-02-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116018/#review50821 --- This review has been submitted with commit 6277f5d8acbca3704d

Re: Review Request 116018: Add a FindWayland module

2014-02-25 Thread Alex Merry
> On Feb. 25, 2014, 12:54 p.m., Alex Merry wrote: > > find-modules/FindWayland.cmake, line 192 > > > > > > You know this is going be printed as something like > > > > "Wayland, Wayland compositor infrast

Re: Review Request 116018: Add a FindWayland module

2014-02-25 Thread Martin Gräßlin
> On Feb. 25, 2014, 1:54 p.m., Alex Merry wrote: > > find-modules/FindWayland.cmake, line 192 > > > > > > You know this is going be printed as something like > > > > "Wayland, Wayland compositor infrastr

Re: Review Request 116018: Add a FindWayland module

2014-02-25 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116018/#review50815 --- Ship it! Just put a better description, and then ship it. f

Re: Review Request 116018: Add a FindWayland module

2014-02-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116018/ --- (Updated Feb. 25, 2014, 1:46 p.m.) Review request for Build System, Extra

Re: Review Request 116018: Add a FindWayland module

2014-02-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116018/ --- (Updated Feb. 25, 2014, 1:08 p.m.) Review request for Build System, Extra

Re: Review Request 116018: Add a FindWayland module

2014-02-25 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116018/#review50798 --- find-modules/FindWayland.cmake

Re: Review Request 116018: Add a FindWayland module

2014-02-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116018/ --- (Updated Feb. 25, 2014, 8:46 a.m.) Review request for Build System, Extra

Re: Review Request 116018: Add a FindWayland module

2014-02-24 Thread Alex Merry
> On Feb. 24, 2014, 2:55 p.m., Alex Merry wrote: > > Same comments as for FindEGL.cmake: > > - what projects are using it? I guess KWin is one; any others? > > - it needs to set the DESCRIPTION and URL package properties (from > > FeatureSummary) > > - I've been aiming to create imported target

Re: Review Request 116018: Add a FindWayland module

2014-02-24 Thread Martin Gräßlin
> On Feb. 24, 2014, 3:55 p.m., Alex Merry wrote: > > Same comments as for FindEGL.cmake: > > - what projects are using it? I guess KWin is one; any others? > > - it needs to set the DESCRIPTION and URL package properties (from > > FeatureSummary) > > - I've been aiming to create imported target

Re: Review Request 116018: Add a FindWayland module

2014-02-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116018/#review50706 --- Same comments as for FindEGL.cmake: - what projects are using

Review Request 116018: Add a FindWayland module

2014-02-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116018/ --- Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake