Re: Review Request 116014: Add a FindEgl module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116014/#review50814 --- This review has been submitted with commit a2ada35b5c768e8efe

Re: Review Request 116014: Add a FindEgl module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116014/ --- (Updated Feb. 25, 2014, 12:51 p.m.) Status -- This change has been m

Re: Review Request 116014: Add a FindEgl module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116014/#review50811 --- Ship it! Ship It! - Alex Merry On Feb. 25, 2014, 12:42 p.m

Re: Review Request 116014: Add a FindEgl module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116014/ --- (Updated Feb. 25, 2014, 1:42 p.m.) Review request for Build System, Extra

Re: Review Request 116014: Add a FindEgl module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116014/ --- (Updated Feb. 25, 2014, 1:12 p.m.) Review request for Build System, Extra

Re: Review Request 116014: Add a FindEgl module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116014/#review50804 --- find-modules/FindEgl.cmake

Re: Review Request 116014: Add a FindEgl module

> On Feb. 25, 2014, 11:46 a.m., Alex Merry wrote: > > Generally looks good, but I'm wondering about the WIN32 clause. EGL is > > really just an API, right? What we're really searching for is the Mesa > > implementation. I guess that other platforms may well have their own > > implementation

Re: Review Request 116014: Add a FindEgl module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116014/ --- (Updated Feb. 25, 2014, 1:02 p.m.) Review request for Build System, Extra

Re: Review Request 116014: Add a FindEgl module

> On Feb. 25, 2014, 12:46 p.m., Alex Merry wrote: > > Generally looks good, but I'm wondering about the WIN32 clause. EGL is > > really just an API, right? What we're really searching for is the Mesa > > implementation. I guess that other platforms may well have their own > > implementation

Re: Review Request 116014: Add a FindEgl module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116014/#review50800 --- Generally looks good, but I'm wondering about the WIN32 clause

Re: Review Request 116014: Add a FindEgl module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116014/ --- (Updated Feb. 25, 2014, 11:21 a.m.) Review request for Build System, Extr

Re: Review Request 116014: Add a FindEgl module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116014/ --- (Updated Feb. 25, 2014, 9:13 a.m.) Review request for Build System, Extra

Re: Review Request 116014: Add a FindEgl module

> On Feb. 24, 2014, 2:51 p.m., Alex Merry wrote: > > Three things: > > - what projects are using it? I guess KWin is one; any others? > > - it needs to set the DESCRIPTION and URL package properties (from > > FeatureSummary) > > - I've been aiming to create imported targets in new find modules,

Re: Review Request 116014: Add a FindEgl module

> On Feb. 24, 2014, 3:51 p.m., Alex Merry wrote: > > Three things: > > - what projects are using it? I guess KWin is one; any others? > > - it needs to set the DESCRIPTION and URL package properties (from > > FeatureSummary) > > - I've been aiming to create imported targets in new find modules,

Re: Review Request 116014: Add a FindEgl module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116014/#review50705 --- Three things: - what projects are using it? I guess KWin is o

Re: Review Request 116014: Add a FindEgl module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116014/ --- (Updated Feb. 24, 2014, 2:08 p.m.) Review request for KDE Frameworks and

Review Request 116014: Add a FindEgl module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116014/ --- Review request for KDE Frameworks. Repository: extra-cmake-modules Desc