Re: Review Request 115932: Add declarative plugin for KWindowSystem

2014-03-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115932/ --- (Updated March 4, 2014, 8:41 p.m.) Status -- This change has been di

Re: Review Request 115932: Add declarative plugin for KWindowSystem

2014-02-27 Thread Martin Klapetek
> On Feb. 27, 2014, 10:54 a.m., Martin Gräßlin wrote: > > I think the example app needs to be more complete as I doubt that > > everything here would just work (e.g. the States). If you are unsure about > > how that should work I can schedule some time for it. > > > > Would it be possible to a

Re: Review Request 115932: Add declarative plugin for KWindowSystem

2014-02-27 Thread Martin Gräßlin
> On Feb. 27, 2014, 10:54 a.m., Martin Gräßlin wrote: > > I think the example app needs to be more complete as I doubt that > > everything here would just work (e.g. the States). If you are unsure about > > how that should work I can schedule some time for it. > > > > Would it be possible to a

Re: Review Request 115932: Add declarative plugin for KWindowSystem

2014-02-27 Thread Martin Klapetek
> On Feb. 27, 2014, 10:54 a.m., Martin Gräßlin wrote: > > I think the example app needs to be more complete as I doubt that > > everything here would just work (e.g. the States). If you are unsure about > > how that should work I can schedule some time for it. > > > > Would it be possible to a

Re: Review Request 115932: Add declarative plugin for KWindowSystem

2014-02-27 Thread Martin Gräßlin
> On Feb. 27, 2014, 10:54 a.m., Martin Gräßlin wrote: > > I think the example app needs to be more complete as I doubt that > > everything here would just work (e.g. the States). If you are unsure about > > how that should work I can schedule some time for it. > > > > Would it be possible to a

Re: Review Request 115932: Add declarative plugin for KWindowSystem

2014-02-27 Thread Martin Klapetek
> On Feb. 27, 2014, 10:54 a.m., Martin Gräßlin wrote: > > I think the example app needs to be more complete as I doubt that > > everything here would just work (e.g. the States). If you are unsure about > > how that should work I can schedule some time for it. > > > > Would it be possible to a

Re: Review Request 115932: Add declarative plugin for KWindowSystem

2014-02-27 Thread Martin Gräßlin
> On Feb. 27, 2014, 10:54 a.m., Martin Gräßlin wrote: > > I think the example app needs to be more complete as I doubt that > > everything here would just work (e.g. the States). If you are unsure about > > how that should work I can schedule some time for it. > > > > Would it be possible to a

Re: Review Request 115932: Add declarative plugin for KWindowSystem

2014-02-27 Thread Ivan Čukić
> On Feb. 27, 2014, 9:54 a.m., Martin Gräßlin wrote: > > I think the example app needs to be more complete as I doubt that > > everything here would just work (e.g. the States). If you are unsure about > > how that should work I can schedule some time for it. > > > > Would it be possible to ad

Re: Review Request 115932: Add declarative plugin for KWindowSystem

2014-02-27 Thread Ivan Čukić
> On Feb. 27, 2014, 9:54 a.m., Martin Gräßlin wrote: > > I think the example app needs to be more complete as I doubt that > > everything here would just work (e.g. the States). If you are unsure about > > how that should work I can schedule some time for it. > > > > Would it be possible to ad

Re: Review Request 115932: Add declarative plugin for KWindowSystem

2014-02-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115932/#review51011 --- I think the example app needs to be more complete as I doubt t

Re: Review Request 115932: Add declarative plugin for KWindowSystem

2014-02-27 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115932/ --- (Updated Feb. 27, 2014, 10:23 a.m.) Review request for KDE Frameworks and

Re: Review Request 115932: Add declarative plugin for KWindowSystem

2014-02-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115932/#review50468 --- the approach looks good to me, just two small requests: * make

Review Request 115932: Add declarative plugin for KWindowSystem

2014-02-21 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115932/ --- Review request for KDE Frameworks and Martin Gräßlin. Repository: kwindow