Re: Review Request 115818: Support more catalogs and reduce code duplication

2014-02-19 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115818/ --- (Updated Feb. 19, 2014, 11:51 p.m.) Status -- This change has been m

Re: Review Request 115818: Support more catalogs and reduce code duplication

2014-02-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115818/#review50295 --- This review has been submitted with commit 341c7f48af628a3d9d

Re: Review Request 115818: Support more catalogs and reduce code duplication

2014-02-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115818/#review50294 --- This review has been submitted with commit aacda6f30012e6af1b

Re: Review Request 115818: Support more catalogs and reduce code duplication

2014-02-19 Thread Alex Merry
> On Feb. 19, 2014, 3:07 p.m., Alex Merry wrote: > > Looks good. On the whole, I think this would be better as two separate > > commits (from the POV of git bisect), but I'm not going to push that. > > Luigi Toscano wrote: > Thanks; how would you break it? Do the de-duplication first (cal

Re: Review Request 115818: Support more catalogs and reduce code duplication

2014-02-19 Thread Luigi Toscano
> On Feb. 19, 2014, 3:07 p.m., Alex Merry wrote: > > Looks good. On the whole, I think this would be better as two separate > > commits (from the POV of git bisect), but I'm not going to push that. Thanks; how would you break it? - Luigi

Re: Review Request 115818: Support more catalogs and reduce code duplication

2014-02-19 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115818/#review50252 --- Ship it! Looks good. On the whole, I think this would be bet

Review Request 115818: Support more catalogs and reduce code duplication

2014-02-16 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115818/ --- Review request for Documentation and KDE Frameworks. Repository: kdoctool