Re: Review Request 115749: Use FindShareMimeInfo.cmake from extra-cmake-modules

2014-02-15 Thread Alex Merry
> On Feb. 15, 2014, 12:13 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 3d931552b72972adb0cefe79cc4d9586671d5224 by Alex Merry to branch master. Oops, I got confused between this and https://git.reviewboard.kde.org/r/115748/, and committed that one instead. - Al

Re: Review Request 115749: Use FindShareMimeInfo.cmake from extra-cmake-modules

2014-02-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115749/#review49841 --- This review has been submitted with commit 0064d8e68996d78ef8

Re: Review Request 115749: Use FindShareMimeInfo.cmake from extra-cmake-modules

2014-02-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115749/#review49814 --- This review has been submitted with commit 3d931552b72972adb0

Re: Review Request 115749: Use FindShareMimeInfo.cmake from extra-cmake-modules

2014-02-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115749/ --- (Updated Feb. 15, 2014, 12:13 p.m.) Status -- This change has been m

Re: Review Request 115749: Use FindShareMimeInfo.cmake from extra-cmake-modules

2014-02-14 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115749/#review49802 --- Ship it! Code and testing look good to me. I was surprised to

Review Request 115749: Use FindShareMimeInfo.cmake from extra-cmake-modules

2014-02-14 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115749/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description