Re: Review Request 115700: Remove unused frameworkintegration dependencies

2014-02-16 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115700/ --- (Updated Feb. 16, 2014, 2:31 p.m.) Status -- This change has been di

Re: Review Request 115700: Remove unused frameworkintegration dependencies

2014-02-16 Thread Alex Merry
> On Feb. 16, 2014, 11:25 a.m., Alex Merry wrote: > > Just noticed this. It interacts a little with > > https://git.reviewboard.kde.org/r/115773/ (which implemented David's > > suggestion to make KStyle not build standalone any more). So, in term of actual recommendations, I would commit the

Re: Review Request 115700: Remove unused frameworkintegration dependencies

2014-02-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115700/#review49906 --- Just noticed this. It interacts a little with https://git.re

Re: Review Request 115700: Remove unused frameworkintegration dependencies

2014-02-15 Thread David Faure
> On Feb. 15, 2014, 7:24 p.m., David Faure wrote: > > Ship It! Actually the feature_summary line should be removed. More stuff in kstyle/CMakeLists.txt should be cleaned up, there's no reason to build it standalone. - David --- This i

Re: Review Request 115700: Remove unused frameworkintegration dependencies

2014-02-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115700/#review49860 --- Ship it! Ship It! - David Faure On Feb. 12, 2014, 3:38 p.m

Review Request 115700: Remove unused frameworkintegration dependencies

2014-02-12 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115700/ --- Review request for KDE Frameworks and Àlex Fiestas. Repository: framework