Re: Review Request 115610: Hide private method behind the d-pointer in KLineEdit

2014-02-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115610/#review50175 --- This review has been submitted with commit 63a1847b2a73302dd1

Re: Review Request 115610: Hide private method behind the d-pointer in KLineEdit

2014-02-18 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115610/ --- (Updated Feb. 18, 2014, 8:59 p.m.) Status -- This change has been ma

Re: Review Request 115610: Hide private method behind the d-pointer in KLineEdit

2014-02-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115610/#review50128 --- Ship it! Ship It! - David Faure On Feb. 9, 2014, 11:07 p.m

Re: Review Request 115610: Hide private method behind the d-pointer in KLineEdit

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115610/#review49761 --- Looks good to me, but it is a rather large diff, so I think so

Re: Review Request 115610: Hide private method behind the d-pointer in KLineEdit

2014-02-12 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115610/#review49684 --- Ping? Should I send this patch differently or something? - Da

Review Request 115610: Hide private method behind the d-pointer in KLineEdit

2014-02-09 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115610/ --- Review request for KDE Frameworks. Repository: kcompletion Description