Re: Review Request 115541: Build fix for Mac OS X

2014-02-12 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115541/ --- (Updated Feb. 12, 2014, 9:05 a.m.) Status -- This change has been di

Re: Review Request 115541: Build fix for Mac OS X

2014-02-10 Thread Harald Fernengel
> On Feb. 8, 2014, 10:07 a.m., David Faure wrote: > > Urgh, we were hoping this wouldn't be an issue. > > > > This commit would break #include , so it cannot go in. > > > > All "namespaced" frameworks do it this way already btw, see kparts for > > instance: > > > > -- Up-to-date: > > /d/kde/

Re: Review Request 115541: Build fix for Mac OS X

2014-02-09 Thread David Faure
> On Feb. 8, 2014, 10:07 a.m., David Faure wrote: > > Urgh, we were hoping this wouldn't be an issue. > > > > This commit would break #include , so it cannot go in. > > > > All "namespaced" frameworks do it this way already btw, see kparts for > > instance: > > > > -- Up-to-date: > > /d/kde/

Re: Review Request 115541: Build fix for Mac OS X

2014-02-08 Thread Harald Fernengel
> On Feb. 8, 2014, 10:07 a.m., David Faure wrote: > > Urgh, we were hoping this wouldn't be an issue. > > > > This commit would break #include , so it cannot go in. > > > > All "namespaced" frameworks do it this way already btw, see kparts for > > instance: > > > > -- Up-to-date: > > /d/kde/

Re: Review Request 115541: Build fix for Mac OS X

2014-02-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115541/#review49240 --- Urgh, we were hoping this wouldn't be an issue. This commit w

Review Request 115541: Build fix for Mac OS X

2014-02-07 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115541/ --- Review request for KDE Frameworks. Repository: attica Description -