Re: Review Request 115485: Porting KTranscript from KJS to QtScript

> On Feb. 22, 2014, 3:24 p.m., Michael Palimaka wrote: > > If this is tier 1 now, please don't forget to update the wiki and the yaml > > file. > > Hrvoje Senjan wrote: > Also find_dependency(KF5JS "@KF5_VERSION@") can go away =) Both good catches. All in now - Kevin --

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

> On Feb. 22, 2014, 3:24 p.m., Michael Palimaka wrote: > > If this is tier 1 now, please don't forget to update the wiki and the yaml > > file. Also find_dependency(KF5JS "@KF5_VERSION@") can go away =) - Hrvoje --- This is an automati

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/#review50535 --- If this is tier 1 now, please don't forget to update the wiki

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

> On Feb. 22, 2014, 1:35 p.m., Chusslove Illich wrote: > > I tried to run a standalone non-GUI program using ki18n: > > > > #include > > #include > > > > int main (int argc, char *argv[]) > > { > > setlocale (LC_ALL, ""); > > KLocalizedString::setApplicationDomain("test-ki

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/ --- (Updated Feb. 22, 2014, 2:15 p.m.) Status -- This change has been ma

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/#review50532 --- This review has been submitted with commit 6d405c31ac624b4ea8

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/#review50531 --- Ship it! Ship It! - Chusslove Illich On Feb. 22, 2014, 3 p

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

> On Feb. 22, 2014, 2:35 p.m., Chusslove Illich wrote: > > I tried to run a standalone non-GUI program using ki18n: > > > > #include > > #include > > > > int main (int argc, char *argv[]) > > { > > setlocale (LC_ALL, ""); > > KLocalizedString::setApplicationDomain("test-ki

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/ --- (Updated Feb. 22, 2014, 2 p.m.) Review request for KDE Frameworks and Chu

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

> On Feb. 22, 2014, 2:35 p.m., Chusslove Illich wrote: > > I tried to run a standalone non-GUI program using ki18n: > > > > #include > > #include > > > > int main (int argc, char *argv[]) > > { > > setlocale (LC_ALL, ""); > > KLocalizedString::setApplicationDomain("test-ki

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/ --- (Updated Feb. 22, 2014, 1:58 p.m.) Review request for KDE Frameworks and

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

> On Feb. 22, 2014, 1:35 p.m., Chusslove Illich wrote: > > I tried to run a standalone non-GUI program using ki18n: > > > > #include > > #include > > > > int main (int argc, char *argv[]) > > { > > setlocale (LC_ALL, ""); > > KLocalizedString::setApplicationDomain("test-ki

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

> On Feb. 22, 2014, 1:35 p.m., Chusslove Illich wrote: > > I tried to run a standalone non-GUI program using ki18n: > > > > #include > > #include > > > > int main (int argc, char *argv[]) > > { > > setlocale (LC_ALL, ""); > > KLocalizedString::setApplicationDomain("test-ki

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/#review50522 --- I tried to run a standalone non-GUI program using ki18n: #i

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/ --- (Updated Feb. 21, 2014, 4:30 p.m.) Review request for KDE Frameworks and

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

> On Feb. 20, 2014, 2:36 p.m., Kevin Ottens wrote: > > Any concerns left on that patch? It'd be nice to have it in alpha 2. > > Kevin Krammer wrote: > I guess the main problem is that due to a weird JavaScriptCore internal > thing the unit test crashes on exit. > See https://bugreports.

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

> On Feb. 20, 2014, 2:36 p.m., Kevin Ottens wrote: > > Any concerns left on that patch? It'd be nice to have it in alpha 2. I guess the main problem is that due to a weird JavaScriptCore internal thing the unit test crashes on exit. See https://bugreports.qt-project.org/browse/QTBUG-9622 for re

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/#review50376 --- Any concerns left on that patch? It'd be nice to have it in al

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

> On Feb. 16, 2014, 5:22 p.m., Albert Astals Cid wrote: > > src/ktranscript.cpp, line 1489 > > > > > > Kill the qdebug (and the one a bit below)? good catch, thanks - Kevin -

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/ --- (Updated Feb. 16, 2014, 6:54 p.m.) Review request for KDE Frameworks and

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/#review49941 --- Do you have any idea at why the shutdown crash may be happenin

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

> On Feb. 5, 2014, 3:51 p.m., Aurélien Gâteau wrote: > > Wow, great work! I attempted doing this some time ago, and all I managed to > > produce was two unit tests :). Looks good to me and works fine here. Just > > two (really minor) nitpicks. > > Kevin Krammer wrote: > Thanks :) > Goo

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/ --- (Updated Feb. 16, 2014, 4:02 p.m.) Review request for KDE Frameworks and

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

> On Feb. 5, 2014, 4:51 p.m., Aurélien Gâteau wrote: > > Wow, great work! I attempted doing this some time ago, and all I managed to > > produce was two unit tests :). Looks good to me and works fine here. Just > > two (really minor) nitpicks. > > Kevin Krammer wrote: > Thanks :) > Goo

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

> On Feb. 5, 2014, 3:51 p.m., Aurélien Gâteau wrote: > > Wow, great work! I attempted doing this some time ago, and all I managed to > > produce was two unit tests :). Looks good to me and works fine here. Just > > two (really minor) nitpicks. > > Kevin Krammer wrote: > Thanks :) > Goo

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

On Wednesday 05 February 2014 22:18:54 Chusslove Illich wrote: > I don't see significant benefit in ki18n being tier 1 Maybe not significant, but looking at ever-appearing difficulties with providing proper translations of Qt applications in KDE repositories, the porting effort is worth it. Chr

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

> On Feb. 5, 2014, 4:51 p.m., Aurélien Gâteau wrote: > > Wow, great work! I attempted doing this some time ago, and all I managed to > > produce was two unit tests :). Looks good to me and works fine here. Just > > two (really minor) nitpicks. > > Kevin Krammer wrote: > Thanks :) > Goo

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

> On Feb. 5, 2014, 3:51 p.m., Aurélien Gâteau wrote: > > Wow, great work! I attempted doing this some time ago, and all I managed to > > produce was two unit tests :). Looks good to me and works fine here. Just > > two (really minor) nitpicks. Thanks :) Good to hear that it works properly, I g

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/ --- (Updated Feb. 5, 2014, 4:08 p.m.) Review request for KDE Frameworks and C

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/#review49036 --- Wow, great work! I attempted doing this some time ago, and all

Review Request 115485: Porting KTranscript from KJS to QtScript

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/ --- Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n