Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/#review49135 --- This review has been submitted with commit 58d46fc44abb73d960

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/ --- (Updated Feb. 6, 2014, 2:22 p.m.) Status -- This change has been mar

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

> On Feb. 6, 2014, 2:14 a.m., Alexander Richardson wrote: > > src/kwindowsystem.cpp, line 342 > > > > > > The non-MSVC macro has a return statement, I think this one needs it as > > well > > Andrius da Costa

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/#review49113 --- Ship it! Ship It! - Alexander Richardson On Feb. 6, 2014,

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/#review49095 --- Ship it! Looks good to me. - Aurélien Gâteau On Feb. 6, 20

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/ --- (Updated Feb. 6, 2014, 10:19 a.m.) Review request for KDE Frameworks, kde

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

> On Feb. 6, 2014, 2:14 a.m., Alexander Richardson wrote: > > src/kwindowsystem.cpp, line 342 > > > > > > The non-MSVC macro has a return statement, I think this one needs it as > > well > > Andrius da Costa

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

> On Feb. 6, 2014, 1:14 a.m., Alexander Richardson wrote: > > src/kwindowsystem.cpp, line 342 > > > > > > The non-MSVC macro has a return statement, I think this one needs it as > > well Why is this condition

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/#review49088 --- src/kwindowsystem.cpp

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

> On Feb. 4, 2014, 5:19 p.m., Aurélien Gâteau wrote: > > Any particular reason for not using an abstract class? The D macro makes > > the code a bit surprising to read. > > Martin Gräßlin wrote: > see discussion of https://git.reviewboard.kde.org/r/115225/ (comment > thread started by Aaro

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/ --- (Updated Feb. 5, 2014, 5:55 p.m.) Review request for KDE Frameworks, kdew

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

> On Feb. 4, 2014, 5:19 p.m., Aurélien Gâteau wrote: > > Any particular reason for not using an abstract class? The D macro makes > > the code a bit surprising to read. > > Martin Gräßlin wrote: > see discussion of https://git.reviewboard.kde.org/r/115225/ (comment > thread started by Aaro

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

> On Feb. 4, 2014, 5:19 p.m., Aurélien Gâteau wrote: > > Any particular reason for not using an abstract class? The D macro makes > > the code a bit surprising to read. > > Martin Gräßlin wrote: > see discussion of https://git.reviewboard.kde.org/r/115225/ (comment > thread started by Aaro

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/ --- (Updated Feb. 5, 2014, 4:46 p.m.) Review request for KDE Frameworks, kdew

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

> On Feb. 4, 2014, 5:19 p.m., Aurélien Gâteau wrote: > > Any particular reason for not using an abstract class? The D macro makes > > the code a bit surprising to read. see discussion of https://git.reviewboard.kde.org/r/115225/ (comment thread started by Aaron) - I wanted to keep the same pat

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/#review48978 --- src/kwindowsystem.cpp

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/#review48975 --- src/kwindowsystem.cpp

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/#review48944 --- Any particular reason for not using an abstract class? The D m

Review Request 115459: Introduce runtime platform support in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/ --- Review request for KDE Frameworks, kdewin and Alexander Richardson. Repos