Re: Review Request 115395: Also pass -fno-exceptions when building with clang

2014-03-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395/#review51982 --- This review has been submitted with commit 3b5c422eff53161b52

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

2014-03-04 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395/ --- (Updated March 4, 2014, 10:22 p.m.) Status -- This change has been m

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

2014-03-04 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395/#review51974 --- Ship it! Let's give it a try as the situation in frameworks l

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

2014-03-04 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395/ --- (Updated March 4, 2014, 10:02 p.m.) Review request for Build System, Extr

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

2014-03-04 Thread Kevin Ottens
> On Feb. 3, 2014, 6:07 p.m., Raphael Kubo da Costa wrote: > > Please see the big comment below the elseif line, the link to the > > kde-core-devel and > > http://lists.kde.org/?l=kde-core-devel&m=138244424421211&w=2: the issue > > here is that if you pass -fno-exceptions to clang you need to

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

2014-02-22 Thread Alexander Richardson
> On Feb. 3, 2014, 7:07 p.m., Raphael Kubo da Costa wrote: > > Please see the big comment below the elseif line, the link to the > > kde-core-devel and > > http://lists.kde.org/?l=kde-core-devel&m=138244424421211&w=2: the issue > > here is that if you pass -fno-exceptions to clang you need to

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

2014-02-20 Thread Kevin Ottens
> On Feb. 3, 2014, 6:07 p.m., Raphael Kubo da Costa wrote: > > Please see the big comment below the elseif line, the link to the > > kde-core-devel and > > http://lists.kde.org/?l=kde-core-devel&m=138244424421211&w=2: the issue > > here is that if you pass -fno-exceptions to clang you need to

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

2014-02-19 Thread Alex Merry
> On Feb. 3, 2014, 6:07 p.m., Raphael Kubo da Costa wrote: > > Please see the big comment below the elseif line, the link to the > > kde-core-devel and > > http://lists.kde.org/?l=kde-core-devel&m=138244424421211&w=2: the issue > > here is that if you pass -fno-exceptions to clang you need to

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

2014-02-03 Thread Raphael Kubo da Costa
> On Feb. 3, 2014, 8:07 p.m., Raphael Kubo da Costa wrote: > > Please see the big comment below the elseif line, the link to the > > kde-core-devel and > > http://lists.kde.org/?l=kde-core-devel&m=138244424421211&w=2: the issue > > here is that if you pass -fno-exceptions to clang you need to

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

2014-02-03 Thread Alexander Richardson
> On Feb. 3, 2014, 7:07 p.m., Raphael Kubo da Costa wrote: > > Please see the big comment below the elseif line, the link to the > > kde-core-devel and > > http://lists.kde.org/?l=kde-core-devel&m=138244424421211&w=2: the issue > > here is that if you pass -fno-exceptions to clang you need to

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

2014-02-03 Thread Alex Merry
> On Feb. 3, 2014, 6:07 p.m., Raphael Kubo da Costa wrote: > > Please see the big comment below the elseif line, the link to the > > kde-core-devel and > > http://lists.kde.org/?l=kde-core-devel&m=138244424421211&w=2: the issue > > here is that if you pass -fno-exceptions to clang you need to

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

2014-02-03 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395/#review48846 --- Please see the big comment below the elseif line, the link to

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

2014-01-29 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395/#review48581 --- kde-modules/KDECompilerSettings.cmake

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

2014-01-29 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395/#review48580 --- Don't forget to also remove the comments about # We never

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

2014-01-29 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395/#review48579 --- kde-modules/KDECompilerSettings.cmake

Review Request 115395: Also pass -fno-exceptions when building with clang

2014-01-29 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.