Re: Review Request 115269: Improve dependency specifications

2014-01-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115269/#review48625 --- This review has been submitted with commit a8e9c0599a2787337b

Re: Review Request 115269: Improve dependency specifications

2014-01-30 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115269/ --- (Updated Jan. 30, 2014, 2:51 p.m.) Status -- This change has been ma

Re: Review Request 115269: Improve dependency specifications

2014-01-30 Thread Michael Palimaka
> On Jan. 30, 2014, 11:47 a.m., Alex Merry wrote: > > CMakeLists.txt, lines 52-55 > > > > > > Make this unconditional (ie: replace all four lines by just the > > find_package line) Will do, thanks. - Michael

Re: Review Request 115269: Improve dependency specifications

2014-01-30 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115269/#review48598 --- Ship it! Looks sensible. Just one thing while you're editing

Re: Review Request 115269: Improve dependency specifications

2014-01-30 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115269/#review48597 --- I would like to commit this soon if there are no comments. -

Review Request 115269: Improve dependency specifications

2014-01-23 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115269/ --- Review request for KDE Frameworks. Repository: kdnssd-framework Descrip