Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC

2014-01-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/#review48133 --- This review has been submitted with commit 506bd64a3b30fbb5c1

Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC

2014-01-23 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/ --- (Updated Jan. 23, 2014, 3:10 p.m.) Status -- This change has been ma

Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC

2014-01-23 Thread Alex Merry
> On Jan. 23, 2014, 9:28 a.m., David Faure wrote: > > Oh, OK, didn't know this was broken on MSVC. Worth a Qt fix or at least > > bugreport? > > Luigi Toscano wrote: > Thiago reported it: see > http://lists.kde.org/?l=kde-buildsystem&m=139042097719628&w=2 and > https://codereview.qt-proje

Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC

2014-01-23 Thread Alexander Richardson
> On Jan. 23, 2014, 10:28 a.m., David Faure wrote: > > Oh, OK, didn't know this was broken on MSVC. Worth a Qt fix or at least > > bugreport? > > Luigi Toscano wrote: > Thiago reported it: see > http://lists.kde.org/?l=kde-buildsystem&m=139042097719628&w=2 and > https://codereview.qt-proj

Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC

2014-01-23 Thread Luigi Toscano
> On Jan. 23, 2014, 9:28 a.m., David Faure wrote: > > Oh, OK, didn't know this was broken on MSVC. Worth a Qt fix or at least > > bugreport? Thiago reported it: see http://lists.kde.org/?l=kde-buildsystem&m=139042097719628&w=2 and https://codereview.qt-project.org/#change,76311 - Luigi --

Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC

2014-01-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/#review48092 --- Ship it! Oh, OK, didn't know this was broken on MSVC. Worth a

Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC

2014-01-22 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.