Re: Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/ --- (Updated Feb. 1, 2014, 8:03 a.m.) Status -- This change has been mar

Re: Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/#review48735 --- This review has been submitted with commit 2bcd51e65f143d995a

Re: Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/#review48712 --- Ship it! I'm not a huge fan of the dark templating magic, and

Re: Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/ --- (Updated Jan. 29, 2014, 8:02 a.m.) Review request for KDE Frameworks and

Re: Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/#review48200 --- Looks good to me, however I think someone else should give the

Re: Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/ --- (Updated Jan. 24, 2014, 9:04 a.m.) Review request for KDE Frameworks and

Re: Review Request 115225: Add runtime platform support to KWindowInfo

> On Jan. 23, 2014, 3:47 p.m., Alexander Richardson wrote: > > Wouldn't this be easier using methods with the subclass as a template > > parameter instead of the enum. I.e: > > > > > > class KWindowSystemPrivate { > > // > > template > > inline unsigned long state() const > > { > > //

Re: Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/#review48124 --- Wouldn't this be easier using methods with the subclass as a t

Re: Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/ --- (Updated Jan. 23, 2014, 9:09 a.m.) Review request for KDE Frameworks and

Re: Review Request 115225: Add runtime platform support to KWindowInfo

> On Jan. 22, 2014, 4:32 p.m., David Edmundson wrote: > > src/kwindowinfo.cpp, line 191 > > > > > > This seems wrong. > > > > KWindowInfo cheese; > > cheese.state(); //CRASH > > I kept the ctor as i

Re: Review Request 115225: Add runtime platform support to KWindowInfo

> On Jan. 22, 2014, 4:22 p.m., Aaron J. Seigo wrote: > > Looks quite nice, other than the missing win/mac support which you can do > > little about at this point. > > > > Use of the explicitly shared pointer approach is a simple and nice > > performance booster when passing these objects aroun

Re: Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/#review48048 --- QSharedData code looks right to me. Thanks. src/kwindowinfo.

Re: Review Request 115225: Add runtime platform support to KWindowInfo

> On Jan. 22, 2014, 3:22 p.m., Aaron J. Seigo wrote: > > Looks quite nice, other than the missing win/mac support which you can do > > little about at this point. > > > > Use of the explicitly shared pointer approach is a simple and nice > > performance booster when passing these objects aroun

Re: Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/#review48044 --- Looks quite nice, other than the missing win/mac support which

Re: Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/ --- (Updated Jan. 22, 2014, 3:03 p.m.) Review request for KDE Frameworks and

Re: Review Request 115225: Add runtime platform support to KWindowInfo

> On Jan. 22, 2014, 2:39 p.m., David Edmundson wrote: > > src/kwindowinfo_p.h, line 80 > > > > > > Why are we ref counting ourselves instead of just using > > QExplicitlySharedDataPointer? because it was that wa

Re: Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/#review48024 --- src/kwindowinfo_p.h

Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/ --- Review request for KDE Frameworks and kdewin. Repository: kwindowsystem