Re: Review Request 114962: Improve dependency specifications

2014-01-15 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114962/ --- (Updated Jan. 15, 2014, 12:13 p.m.) Status -- This change has been m

Re: Review Request 114962: Improve dependency specifications

2014-01-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114962/#review47437 --- This review has been submitted with commit 7e315ef53a9574ee17

Re: Review Request 114962: Improve dependency specifications

2014-01-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114962/#review47436 --- Ship it! Ship It! - David Faure On Jan. 15, 2014, 5:54 a.m

Re: Review Request 114962: Improve dependency specifications

2014-01-14 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114962/ --- (Updated Jan. 15, 2014, 5:54 a.m.) Review request for KDE Frameworks. C

Re: Review Request 114962: Improve dependency specifications

2014-01-13 Thread Alex Merry
> On Jan. 11, 2014, 8:02 p.m., Alex Merry wrote: > > This should be using QT_REQUIRED_VERSION everywhere. Actually, if you > > could change it in the other CMakeLists.txt files, that would be good. > > Then it can be shipped. > > Michael Palimaka wrote: > No worries, will do. I only expl

Re: Review Request 114962: Improve dependency specifications

2014-01-12 Thread Michael Palimaka
> On Jan. 11, 2014, 8:02 p.m., Alex Merry wrote: > > This should be using QT_REQUIRED_VERSION everywhere. Actually, if you > > could change it in the other CMakeLists.txt files, that would be good. > > Then it can be shipped. No worries, will do. I only explicitly wrote the version for consi

Re: Review Request 114962: Improve dependency specifications

2014-01-11 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114962/#review47231 --- Ship it! This should be using QT_REQUIRED_VERSION everywhere.

Review Request 114962: Improve dependency specifications

2014-01-11 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114962/ --- Review request for KDE Frameworks. Repository: kconfig Description