Re: Review Request 114898: Remove use of obsolete add_compiler_export_flags

2014-01-07 Thread Alex Merry
> On Jan. 7, 2014, 7:46 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 676e746b78d8b6ada47dd15fd706d0deb9996e45 by Alex Merry to branch master. > > Alexander Richardson wrote: > A bit late, but how about adding the include(GenerateExportHeader) to > KDECMakeSet

Re: Review Request 114898: Remove use of obsolete add_compiler_export_flags

2014-01-07 Thread Alexander Richardson
> On Jan. 7, 2014, 8:46 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 676e746b78d8b6ada47dd15fd706d0deb9996e45 by Alex Merry to branch master. A bit late, but how about adding the include(GenerateExportHeader) to KDECMakeSettings.cmake, this way the frameworks don

Re: Review Request 114898: Remove use of obsolete add_compiler_export_flags

2014-01-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114898/#review47000 --- This review has been submitted with commit 676e746b78d8b6ada4

Re: Review Request 114898: Remove use of obsolete add_compiler_export_flags

2014-01-07 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114898/ --- (Updated Jan. 7, 2014, 7:46 p.m.) Status -- This change has been mar

Re: Review Request 114898: Remove use of obsolete add_compiler_export_flags

2014-01-07 Thread Alex Merry
> On Jan. 7, 2014, 5:03 p.m., Stephen Kelly wrote: > > Does test code need to be compiled with the flags? I see no reason why it would. It's only really useful for libraries and plugins, as far as I'm aware, which I suspect is why CMake doesn't set it for those targets (just checked that it d

Review Request 114898: Remove use of obsolete add_compiler_export_flags

2014-01-07 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114898/ --- Review request for Build System, KDE Frameworks and Stephen Kelly. Reposi

Re: Review Request 114898: Remove use of obsolete add_compiler_export_flags

2014-01-07 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114898/#review46985 --- Ship it! Does test code need to be compiled with the flags?