Re: Review Request 114478: Add kshareddatacache.h include

2013-12-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114478/#review46183 --- This review has been submitted with commit c48bce3c47a7c160aa

Re: Review Request 114478: Add kshareddatacache.h include

2013-12-27 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114478/ --- (Updated Dec. 27, 2013, 12:13 p.m.) Status -- This change has been m

Re: Review Request 114478: Add kshareddatacache.h include

2013-12-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114478/#review46182 --- Ship it! As per discussion on kde-frameworks list. I'll have

Re: Review Request 114478: Add kshareddatacache.h include

2013-12-17 Thread Albert Astals Cid
> On Dec. 15, 2013, 9:22 p.m., Kevin Ottens wrote: > > It is in fact intended that way as kguiaddons isn't supposed to include > > stuff coming from kcoreaddons (yeah I know it's slightly convoluted in that > > particular case). > > Albert Astals Cid wrote: > So basically we have a header

Re: Review Request 114478: Add kshareddatacache.h include

2013-12-17 Thread Alex Merry
> On Dec. 15, 2013, 9:22 p.m., Kevin Ottens wrote: > > It is in fact intended that way as kguiaddons isn't supposed to include > > stuff coming from kcoreaddons (yeah I know it's slightly convoluted in that > > particular case). > > Albert Astals Cid wrote: > So basically we have a header

Re: Review Request 114478: Add kshareddatacache.h include

2013-12-17 Thread Kevin Ottens
> On Dec. 15, 2013, 9:22 p.m., Kevin Ottens wrote: > > It is in fact intended that way as kguiaddons isn't supposed to include > > stuff coming from kcoreaddons (yeah I know it's slightly convoluted in that > > particular case). > > Albert Astals Cid wrote: > So basically we have a header

Re: Review Request 114478: Add kshareddatacache.h include

2013-12-17 Thread Alex Merry
> On Dec. 15, 2013, 9:22 p.m., Kevin Ottens wrote: > > It is in fact intended that way as kguiaddons isn't supposed to include > > stuff coming from kcoreaddons (yeah I know it's slightly convoluted in that > > particular case). > > Albert Astals Cid wrote: > So basically we have a header

Re: Review Request 114478: Add kshareddatacache.h include

2013-12-15 Thread Albert Astals Cid
> On Dec. 15, 2013, 9:22 p.m., Kevin Ottens wrote: > > It is in fact intended that way as kguiaddons isn't supposed to include > > stuff coming from kcoreaddons (yeah I know it's slightly convoluted in that > > particular case). So basically we have a header that when you include it, it breaks

Re: Review Request 114478: Add kshareddatacache.h include

2013-12-15 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114478/#review45732 --- It is in fact intended that way as kguiaddons isn't supposed to

Review Request 114478: Add kshareddatacache.h include

2013-12-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114478/ --- Review request for KDE Frameworks. Repository: kdelibs Description -