Re: Review Request 113670: Link kde4support privately to QtX11Extras, QtSvg and QtTest

2013-11-08 Thread Alex Merry
> On Nov. 8, 2013, 4:25 p.m., Andrius da Costa Ribas wrote: > > Please use X11 stuff conditionally (Q_WS_X11). There's no need to put conditionals in the file (since the whole thing is conditionally compiled), but the linking should be done conditionally. Specifically, you should take Qt5::X11

Re: Review Request 113670: Link kde4support privately to QtX11Extras, QtSvg and QtTest

2013-11-08 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113670/#review43271 --- Please use X11 stuff conditionally (Q_WS_X11). - Andrius da Co

Re: Review Request 113670: Link kde4support privately to QtX11Extras, QtSvg and QtTest

2013-11-07 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113670/ --- (Updated Nov. 7, 2013, 9:33 p.m.) Review request for KDE Frameworks. Sum