Re: Review Request 113631: Allow compiling kwindowsystem on Windows

2013-11-21 Thread Kevin Ottens
> On Nov. 10, 2013, 5:08 p.m., Patrick von Reth wrote: > > please use winsock2.h instead of winsock.h > > Kevin Ottens wrote: > Alexander? Any chance to see this comment addressed? > > Alexander Richardson wrote: > Oops somehow didn't see that comment. Sure I will fix it right away. Any

Re: Review Request 113631: Allow compiling kwindowsystem on Windows

2013-11-18 Thread Nicolás Alvarez
> On Nov. 18, 2013, 3:39 p.m., Nicolás Alvarez wrote: > > Ship It! This has been incubating for long enough. Remember Patrick's comment though :) - Nicolás --- This is an automatically generated e-mail. To reply, visit: http://git.revie

Re: Review Request 113631: Allow compiling kwindowsystem on Windows

2013-11-18 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113631/#review43905 --- Ship it! Ship It! - Nicolás Alvarez On Nov. 10, 2013, 12:46

Re: Review Request 113631: Allow compiling kwindowsystem on Windows

2013-11-15 Thread Alexander Richardson
> On Nov. 10, 2013, 6:08 p.m., Patrick von Reth wrote: > > please use winsock2.h instead of winsock.h > > Kevin Ottens wrote: > Alexander? Any chance to see this comment addressed? Oops somehow didn't see that comment. Sure I will fix it right away. Any other objections or can I commit aft

Re: Review Request 113631: Allow compiling kwindowsystem on Windows

2013-11-15 Thread Kevin Ottens
> On Nov. 10, 2013, 5:08 p.m., Patrick von Reth wrote: > > please use winsock2.h instead of winsock.h Alexander? Any chance to see this comment addressed? - Kevin --- This is an automatically generated e-mail. To reply, visit: http://gi

Re: Review Request 113631: Allow compiling kwindowsystem on Windows

2013-11-10 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113631/#review43369 --- please use winsock2.h instead of winsock.h - Patrick von Reth

Re: Review Request 113631: Allow compiling kwindowsystem on Windows

2013-11-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113631/ --- (Updated Nov. 10, 2013, 3:46 p.m.) Review request for KDE Frameworks, Patr

Re: Review Request 113631: Allow compiling kwindowsystem on Windows

2013-11-05 Thread Martin Gräßlin
> On Nov. 5, 2013, 4:09 p.m., Kevin Ottens wrote: > > Looks ok to me. I'd like someone with more knowledge of KWindowSystem > > and/or windows to look at it though. I cannot comment on the Windows bit, but the cmake stuff around it looks good to me. - Martin ---

Re: Review Request 113631: Allow compiling kwindowsystem on Windows

2013-11-05 Thread Alexander Richardson
> On Nov. 6, 2013, 12:26 a.m., Nicolás Alvarez wrote: > > I just tried this on Windows 7, MSVC 2010, 32-bit. The library itself > > compiles. The autotests ask for X11 headers though; it seems some of the > > autotests have to be disabled altogether on Windows. > > > > In addition, the only ma

Re: Review Request 113631: Allow compiling kwindowsystem on Windows

2013-11-05 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113631/#review43127 --- I just tried this on Windows 7, MSVC 2010, 32-bit. The library

Re: Review Request 113631: Allow compiling kwindowsystem on Windows

2013-11-05 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113631/#review43071 --- Looks ok to me. I'd like someone with more knowledge of KWindow

Review Request 113631: Allow compiling kwindowsystem on Windows

2013-11-04 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113631/ --- Review request for KDE Frameworks. Repository: kdelibs Description -