Re: Review Request 113388: Port knewstuff from KImageIO to QImageReader

2013-10-23 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113388/ --- (Updated Oct. 23, 2013, 7:54 p.m.) Status -- This change has been mar

Re: Review Request 113388: Port knewstuff from KImageIO to QImageReader

2013-10-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113388/#review42257 --- Ship it! Looks good to me (although you left an odd bit of whi

Re: Review Request 113388: Port knewstuff from KImageIO to QImageReader

2013-10-23 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113388/ --- (Updated Oct. 23, 2013, 3:45 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 113388: Port knewstuff from KImageIO to QImageReader

2013-10-22 Thread Jeremy Whiting
> On Oct. 22, 2013, 10:46 a.m., Alex Merry wrote: > > knewstuff/src/uploaddialog.cpp, lines 823-833 > > > > > > Does this actually produce a list of the right form? It looks like it > > will generate something l

Re: Review Request 113388: Port knewstuff from KImageIO to QImageReader

2013-10-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113388/#review42163 --- knewstuff/src/uploaddialog.cpp

Review Request 113388: Port knewstuff from KImageIO to QImageReader

2013-10-22 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113388/ --- Review request for KDE Frameworks. Repository: kdelibs Description -