---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113197/
---
(Updated Oct. 14, 2013, 2 p.m.)
Status
--
This change has been marked
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113197/#review41728
---
This review has been submitted with commit
d16abdc34489e19d671
> On Oct. 14, 2013, 11 a.m., Kevin Ottens wrote:
> > Looks good indeed.
> >
> > Maybe an idea for an improvement: What about having the internal methods
> > use a QScopedPointer on the dialog? It'd avoid the delete before the
> > return, and if someone modifies the file later on adding more su
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113197/#review41682
---
Looks good indeed.
Maybe an idea for an improvement: What abou
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113197/#review41576
---
Ship it!
Looks good.
- David Faure
On Oct. 11, 2013, 8:56 a
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113197/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
-
