Re: Review Request 112942: Move KDNSSD to tier2

2013-10-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112942/ --- (Updated Oct. 3, 2013, 4:25 p.m.) Status -- This change has been mark

Re: Review Request 112942: Move KDNSSD to tier2

2013-10-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112942/#review41186 --- This review has been submitted with commit f719fe660d9be12a201

Re: Review Request 112942: Move KDNSSD to tier2

2013-10-03 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112942/#review41180 --- Ship it! Looks good. - Àlex Fiestas On Oct. 2, 2013, 4:05 p

Re: Review Request 112942: Move KDNSSD to tier2

2013-10-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112942/ --- (Updated Oct. 2, 2013, 4:05 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 112942: Move KDNSSD to tier2

2013-10-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112942/#review41066 --- dnssd/CMakeLists.txt

Re: Review Request 112942: Move KDNSSD to tier2

2013-09-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112942/#review41021 --- ping? - Aleix Pol Gonzalez On Sept. 25, 2013, 5:35 p.m., Ale

Re: Review Request 112942: Move KDNSSD to tier2

2013-09-25 Thread Aleix Pol Gonzalez
> On Sept. 25, 2013, 6:45 p.m., Martin Klapetek wrote: > > Isn't part of the "done" to have unit tests? I'm not a DNSSD developer, I don't know what would apply as a useful test. I agree that it's a bad thing for a framework not to be unit tested though, maybe we can create a tier for those mo

Re: Review Request 112942: Move KDNSSD to tier2

2013-09-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112942/#review40792 --- Isn't part of the "done" to have unit tests? - Martin Klapetek

Review Request 112942: Move KDNSSD to tier2

2013-09-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112942/ --- Review request for KDE Frameworks. Description --- Moves KDNSSD to ti