Re: Review Request 112829: Move XMLGUI to Tier3

2013-09-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112829/ --- (Updated Sept. 26, 2013, 5:24 p.m.) Status -- This change has been ma

Re: Review Request 112829: Move XMLGUI to Tier3

2013-09-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112829/#review40886 --- This review has been submitted with commit 45cc2bd0a4b7ae01009

Re: Review Request 112829: Move XMLGUI to Tier3

2013-09-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112829/#review40684 --- There's a KDE5 TODO in kmainwindow.h to remove the window flags

Re: Review Request 112829: Move XMLGUI to Tier3

2013-09-23 Thread Aurélien Gâteau
> On Sept. 23, 2013, 5:10 p.m., Aurélien Gâteau wrote: > > It does not build standalone for me, linking fails: > > http://paste.kde.org/p05c23fa6 > > > > I tried to do xmlgui last week, but realized it needs more work on the > > underlying frameworks first (which is why I switched to kconfigwi

Re: Review Request 112829: Move XMLGUI to Tier3

2013-09-23 Thread Aleix Pol Gonzalez
> On Sept. 23, 2013, 3:10 p.m., Aurélien Gâteau wrote: > > It does not build standalone for me, linking fails: > > http://paste.kde.org/p05c23fa6 > > > > I tried to do xmlgui last week, but realized it needs more work on the > > underlying frameworks first (which is why I switched to kconfigwi

Re: Review Request 112829: Move XMLGUI to Tier3

2013-09-23 Thread Aleix Pol Gonzalez
> On Sept. 23, 2013, 3:10 p.m., Aurélien Gâteau wrote: > > It does not build standalone for me, linking fails: > > http://paste.kde.org/p05c23fa6 > > > > I tried to do xmlgui last week, but realized it needs more work on the > > underlying frameworks first (which is why I switched to kconfigwi

Re: Review Request 112829: Move XMLGUI to Tier3

2013-09-23 Thread Aleix Pol Gonzalez
> On Sept. 23, 2013, 3:10 p.m., Aurélien Gâteau wrote: > > It does not build standalone for me, linking fails: > > http://paste.kde.org/p05c23fa6 > > > > I tried to do xmlgui last week, but realized it needs more work on the > > underlying frameworks first (which is why I switched to kconfigwi

Re: Review Request 112829: Move XMLGUI to Tier3

2013-09-23 Thread Aurélien Gâteau
> On Sept. 23, 2013, 5:10 p.m., Aurélien Gâteau wrote: > > It does not build standalone for me, linking fails: > > http://paste.kde.org/p05c23fa6 > > > > I tried to do xmlgui last week, but realized it needs more work on the > > underlying frameworks first (which is why I switched to kconfigwi

Re: Review Request 112829: Move XMLGUI to Tier3

2013-09-23 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112829/#review40574 --- It does not build standalone for me, linking fails: http://pas

Re: Review Request 112829: Move XMLGUI to Tier3

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112829/#review40522 --- Ship it! Looks good. - Kevin Ottens On Sept. 19, 2013, 4:44

Review Request 112829: Move XMLGUI to Tier3

2013-09-19 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112829/ --- Review request for KDE Frameworks. Description --- Move xmlgui to tie