Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-11-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/ --- (Updated Nov. 18, 2013, 8:58 a.m.) Status -- This change has been mar

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-11-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/#review43873 --- This review has been submitted with commit b025c4be103313b59a9

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-11-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/ --- (Updated Nov. 6, 2013, 7:28 a.m.) Review request for KDE Frameworks. Cha

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-11-05 Thread Fredrik Höglund
> On Oct. 29, 2013, 2:42 a.m., Fredrik Höglund wrote: > > Looks much better, but it doesn't handle depth 30 pixmaps. > > Martin Gräßlin wrote: > I'm lacking ideas on how to test this. Do you know any application which > uses 30 bit pixmaps? > > Fredrik Höglund wrote: > The default dept

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-11-04 Thread Martin Gräßlin
> On Oct. 29, 2013, 3:42 a.m., Fredrik Höglund wrote: > > Looks much better, but it doesn't handle depth 30 pixmaps. > > Martin Gräßlin wrote: > I'm lacking ideas on how to test this. Do you know any application which > uses 30 bit pixmaps? > > Fredrik Höglund wrote: > The default dept

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-11-04 Thread Fredrik Höglund
> On Oct. 29, 2013, 2:42 a.m., Fredrik Höglund wrote: > > Looks much better, but it doesn't handle depth 30 pixmaps. > > Martin Gräßlin wrote: > I'm lacking ideas on how to test this. Do you know any application which > uses 30 bit pixmaps? The default depth is 30 when you're using the NVI

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-11-04 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/ --- (Updated Nov. 4, 2013, 9:14 a.m.) Review request for KDE Frameworks. Cha

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-11-04 Thread Martin Gräßlin
> On Oct. 29, 2013, 3:42 a.m., Fredrik Höglund wrote: > > Looks much better, but it doesn't handle depth 30 pixmaps. I'm lacking ideas on how to test this. Do you know any application which uses 30 bit pixmaps? - Martin --- This is an

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-10-28 Thread Fredrik Höglund
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/#review42568 --- Looks much better, but it doesn't handle depth 30 pixmaps. ti

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-10-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/ --- (Updated Oct. 24, 2013, 12:22 p.m.) Review request for KDE Frameworks. C

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-10-21 Thread Martin Gräßlin
> On Oct. 9, 2013, 6:39 p.m., Kevin Ottens wrote: > > Any news about that patch? It hasn't seen activity lately. > > Kevin Ottens wrote: > Anybody home? > > FYI I'll close it as discarded if it doesn't have any activity by next > monday. hey, I'm going to pick it up again! Just ha

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-10-21 Thread Kevin Ottens
> On Oct. 9, 2013, 4:39 p.m., Kevin Ottens wrote: > > Any news about that patch? It hasn't seen activity lately. Anybody home? FYI I'll close it as discarded if it doesn't have any activity by next monday. - Kevin --- This is an automa

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-10-09 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/#review41439 --- Any news about that patch? It hasn't seen activity lately. - K

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-09-23 Thread Kevin Ottens
> On Sept. 23, 2013, 10:27 a.m., Kevin Ottens wrote: > > Not that I'm really qualified with xcb code, but it looks ok to me. > > Martin Gräßlin wrote: > no, no. The issues mentioned by Fredrik should be fixed. > > Fredrik Höglund wrote: > Kevin, please don't take this the wrong way, but

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-09-23 Thread Fredrik Höglund
> On Sept. 23, 2013, 10:27 a.m., Kevin Ottens wrote: > > Not that I'm really qualified with xcb code, but it looks ok to me. > > Martin Gräßlin wrote: > no, no. The issues mentioned by Fredrik should be fixed. Kevin, please don't take this the wrong way, but it would be enormously helpful

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-09-23 Thread Martin Gräßlin
> On Sept. 23, 2013, 12:27 p.m., Kevin Ottens wrote: > > Not that I'm really qualified with xcb code, but it looks ok to me. no, no. The issues mentioned by Fredrik should be fixed. - Martin --- This is an automatically generated e-mail

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/#review40515 --- Ship it! Not that I'm really qualified with xcb code, but it l

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-09-17 Thread Fredrik Höglund
> On Sept. 16, 2013, 12:16 p.m., Fredrik Höglund wrote: > > tier1/kwindowsystem/src/kxutils_p.h, line 49 > > > > > > This statement is no longer true. If the pixmap is not an ARGB32 > > pixmap, the function will c

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-09-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/ --- (Updated Sept. 17, 2013, 7:42 a.m.) Review request for KDE Frameworks. C

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-09-16 Thread Martin Gräßlin
> On Sept. 16, 2013, 2:16 p.m., Fredrik Höglund wrote: > > tier1/kwindowsystem/src/kxutils_p.h, line 49 > > > > > > This statement is no longer true. If the pixmap is not an ARGB32 > > pixmap, the function will cr

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-09-16 Thread Fredrik Höglund
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/#review40111 --- tier1/kwindowsystem/src/kxutils.cpp

Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-09-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/ --- Review request for KDE Frameworks. Description --- Implements the cre