Re: Review Request 112536: Move KUnitConversion to tier2

2013-09-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112536/ --- (Updated Sept. 5, 2013, 5:58 p.m.) Status -- This change has been mar

Re: Review Request 112536: Move KUnitConversion to tier2

2013-09-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112536/#review39426 --- This review has been submitted with commit 1add3fa248d92294130

Re: Review Request 112536: Move KUnitConversion to tier2

2013-09-05 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112536/#review39419 --- staging/kdoctools/KDocToolsMacros.cmake

Re: Review Request 112536: Move KUnitConversion to tier2

2013-09-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112536/ --- (Updated Sept. 5, 2013, 3:05 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 112536: Move KUnitConversion to tier2

2013-09-05 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112536/#review39421 --- Ship it! This is fine, thanks. Please add the cmake related ch

Re: Review Request 112536: Move KUnitConversion to tier2

2013-09-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112536/ --- (Updated Sept. 5, 2013, 3:17 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 112536: Move KUnitConversion to tier2

2013-09-05 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112536/#review39417 --- Before you move kunitconversion, please add the necessary find_

Review Request 112536: Move KUnitConversion to tier2

2013-09-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112536/ --- Review request for KDE Frameworks. Description --- I had to tell it t