Re: Review Request 112453: Remove remove_definitions(..) from KGuiAddons CMakeLists

2013-09-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112453/#review39195 --- This review has been submitted with commit e4bed2b333b26497c27

Re: Review Request 112453: Remove remove_definitions(..) from KGuiAddons CMakeLists

2013-09-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112453/ --- (Updated Sept. 2, 2013, 5:55 p.m.) Status -- This change has been mar

Re: Review Request 112453: Remove remove_definitions(..) from KGuiAddons CMakeLists

2013-09-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112453/#review39181 --- Ship it! I suppose QStringLiteral would be better in the place

Review Request 112453: Remove remove_definitions(..) from KGuiAddons CMakeLists

2013-09-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112453/ --- Review request for KDE Frameworks. Description --- This is a preparat