Re: Review Request 112331: Splitting KUnitConversion

2013-09-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112331/#review39138 --- This review has been submitted with commit 86a8bf726924692c46a

Re: Review Request 112331: Splitting KUnitConversion

2013-09-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112331/ --- (Updated Sept. 2, 2013, 10:46 a.m.) Status -- This change has been ma

Re: Review Request 112331: Splitting KUnitConversion

2013-08-31 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112331/#review39040 --- staging/kunitconversion/src/kunitconversion/CMakeLists.txt

Re: Review Request 112331: Splitting KUnitConversion

2013-08-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112331/ --- (Updated Aug. 31, 2013, 4:12 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 112331: Splitting KUnitConversion

2013-08-31 Thread Aleix Pol Gonzalez
> On Aug. 31, 2013, 7:01 a.m., David Faure wrote: > > Solid seems like a "big" dependency just to know if we're online. > > I would either > > 1) keep the ifdefs for solid, so that someone can easily compile it without > > solid for his own purposes, or > > 2) port it to QNetworkInterface (I did

Re: Review Request 112331: Splitting KUnitConversion

2013-08-31 Thread Aleix Pol Gonzalez
> On Aug. 31, 2013, 7:20 a.m., Chusslove Illich wrote: > > staging/kunitconversion/src/kunitconversion/CMakeLists.txt, line 10 > > > > > > Also the translation domain is configured in config-kunitconversion.h. > >

Re: Review Request 112331: Splitting KUnitConversion

2013-08-31 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112331/#review38987 --- staging/kunitconversion/src/kunitconversion/CMakeLists.txt

Re: Review Request 112331: Splitting KUnitConversion

2013-08-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112331/#review38983 --- Solid seems like a "big" dependency just to know if we're onlin

Review Request 112331: Splitting KUnitConversion

2013-08-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112331/ --- Review request for KDE Frameworks. Description --- Iterates over KUni