Re: Review Request 112185: Fix KManagerSelection and re-enable unit test

2013-08-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112185/#review38396 --- This review has been submitted with commit 182fbab9402ddd0

Re: Review Request 112185: Fix KManagerSelection and re-enable unit test

2013-08-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112185/ --- (Updated Aug. 23, 2013, 5:33 a.m.) Status -- This change has been mar

Re: Review Request 112185: Fix KManagerSelection and re-enable unit test

2013-08-22 Thread Martin Gräßlin
> On Aug. 22, 2013, 2:28 p.m., David Faure wrote: > > tier1/kwindowsystem/src/kmanagerselection.cpp, line 656 > > > > > > that's still a weird if() then, if it does nothing in the body. > > Why not just call o

Re: Review Request 112185: Fix KManagerSelection and re-enable unit test

2013-08-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112185/#review38333 --- Ship it! Many thanks for taking care of this. tier1/kwindows

Review Request 112185: Fix KManagerSelection and re-enable unit test

2013-08-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112185/ --- Review request for KDE Frameworks and David Faure. Description --- Re