Re: Review Request 112151: Use components in FindXCB

2013-09-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/#review39616 --- This review has been submitted with commit c5597c4cf761eeb9d89

Re: Review Request 112151: Use components in FindXCB

2013-09-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/ --- (Updated Sept. 9, 2013, 4:13 a.m.) Status -- This change has been mar

Re: Review Request 112151: Use components in FindXCB

2013-09-04 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/#review39317 --- Ship it! Ship It! - Stephen Kelly On Sept. 4, 2013, 7:45 a.

Re: Review Request 112151: Use components in FindXCB

2013-09-04 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/ --- (Updated Sept. 4, 2013, 9:45 a.m.) Review request for KDE Frameworks, Alex

Re: Review Request 112151: Use components in FindXCB

2013-09-04 Thread Martin Gräßlin
On Sept. 4, 2013, 9:26 a.m., Martin Gräßlin wrote: > > Here's a diff fixing the issues: > > > > diff --git a/find-modules/FindXCB.cmake b/find-modules/FindXCB.cmake > > index 2684ed0..823d167 100644 > > --- a/find-modules/FindXCB.cmake > > +++ b/find-modules/FindXCB.cmake > > @@ -60,9 +60,15 @@

Re: Review Request 112151: Use components in FindXCB

2013-09-04 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/#review39310 --- find-modules/FindXCB.cmake

Re: Review Request 112151: Use components in FindXCB

2013-09-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/ --- (Updated Sept. 4, 2013, 6:57 a.m.) Review request for KDE Frameworks, Alex

Re: Review Request 112151: Use components in FindXCB

2013-09-03 Thread Stephen Kelly
> On Sept. 3, 2013, 9:40 a.m., Stephen Kelly wrote: > > find-modules/FindXCB.cmake, line 187 > > > > > > Is it even possible to hit these fatal errors? I thought find_path and > > find_library would always set th

Re: Review Request 112151: Use components in FindXCB

2013-09-03 Thread Martin Gräßlin
> On Sept. 3, 2013, 11:40 a.m., Stephen Kelly wrote: > > find-modules/FindXCB.cmake, line 187 > > > > > > Is it even possible to hit these fatal errors? I thought find_path and > > find_library would always set t

Re: Review Request 112151: Use components in FindXCB

2013-09-03 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/#review39244 --- find-modules/FindXCB.cmake

Re: Review Request 112151: Use components in FindXCB

2013-09-03 Thread Stephen Kelly
> On Sept. 3, 2013, 8:07 a.m., Stephen Kelly wrote: > > Thanks. > > > > Copying what I wrote before: > > > > > You wrote that it allows having some components be optional, and others > > > be required. However, you don't seem to follow the advice here to do > > > that: > > > http://cmake.org

Re: Review Request 112151: Use components in FindXCB

2013-09-03 Thread Martin Gräßlin
> On Sept. 3, 2013, 10:07 a.m., Stephen Kelly wrote: > > Thanks. > > > > Copying what I wrote before: > > > > > You wrote that it allows having some components be optional, and others > > > be required. However, you don't seem to follow the advice here to do > > > that: > > > http://cmake.or

Re: Review Request 112151: Use components in FindXCB

2013-09-03 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/#review39235 --- Thanks. Copying what I wrote before: > You wrote that it allo

Re: Review Request 112151: Use components in FindXCB

2013-09-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/ --- (Updated Sept. 3, 2013, 9:37 a.m.) Review request for KDE Frameworks, Alex

Re: Review Request 112151: Use components in FindXCB

2013-09-02 Thread Stephen Kelly
> On Aug. 27, 2013, 4:08 p.m., Stephen Kelly wrote: > > find-modules/FindXCB.cmake, line 184 > > > > > > I don't think 'NAMES lib' is correct. That will search for a lib named > > 'lib' with certain patterns, eg

Re: Review Request 112151: Use components in FindXCB

2013-09-02 Thread Martin Gräßlin
> On Aug. 27, 2013, 6:08 p.m., Stephen Kelly wrote: > > find-modules/FindXCB.cmake, line 184 > > > > > > I don't think 'NAMES lib' is correct. That will search for a lib named > > 'lib' with certain patterns, eg

Re: Review Request 112151: Use components in FindXCB

2013-08-27 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/#review38751 --- You wrote that it allows having some components be optional, an

Re: Review Request 112151: Use components in FindXCB

2013-08-20 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/#review38234 --- ...just catching up with email. Big patch ! I'll have a closer

Re: Review Request 112151: Use components in FindXCB

2013-08-19 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/ --- (Updated Aug. 19, 2013, 9:39 a.m.) Review request for KDE Frameworks, Alex

Review Request 112151: Use components in FindXCB

2013-08-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/ --- Review request for KDE Frameworks and Alexander Neundorf. Description