Re: Review Request 112079: Add utility function to paint icon overlays

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/#review38663 --- This review has been submitted with commit 4433027b85e199f11a9

Re: Review Request 112079: Add utility function to paint icon overlays

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/ --- (Updated Aug. 26, 2013, 3:52 p.m.) Status -- This change has been mar

Re: Review Request 112079: Add utility function to paint icon overlays

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/#review38636 --- Ship it! Ship It! - Kevin Ottens On Aug. 26, 2013, 12:07 p.

Re: Review Request 112079: Add utility function to paint icon overlays

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/ --- (Updated Aug. 26, 2013, 12:07 p.m.) Review request for KDE Frameworks. C

Re: Review Request 112079: Add utility function to paint icon overlays

> On Aug. 26, 2013, 6:37 a.m., Kevin Ottens wrote: > > staging/kguiaddons/src/util/kiconutils.h, line 31 > > > > > > Not sure about the use of "draw" here. Those methods don't draw, right? > > > > "Adds" s

Re: Review Request 112079: Add utility function to paint icon overlays

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/#review38570 --- staging/kguiaddons/src/util/kiconutils.h

Re: Review Request 112079: Add utility function to paint icon overlays

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/ --- (Updated Aug. 23, 2013, 9:25 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 112079: Add utility function to paint icon overlays

> On Aug. 17, 2013, 8:39 p.m., Nicolás Alvarez wrote: > > staging/kguiaddons/src/util/qiconoverlay.h, line 31 > > > > > > What about calling this one "AddOverlays", in plural? Dunno, I never much liked different m

Re: Review Request 112079: Add utility function to paint icon overlays

> On Aug. 14, 2013, 3 p.m., Aurélien Gâteau wrote: > > staging/kguiaddons/src/util/qiconoverlay.cpp, line 33 > > > > > > Should be const The virtual engine method is not const (nor is QIcon::actualSize()), so that

Re: Review Request 112079: Add utility function to paint icon overlays

> On Aug. 19, 2013, 9:52 a.m., Kevin Ottens wrote: > > staging/kguiaddons/src/util/qiconoverlay.h, line 29 > > > > > > Apidox is missing for those two functions. The dox is in the .cpp file, I got used to that fro

Re: Review Request 112079: Add utility function to paint icon overlays

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/#review38113 --- staging/kguiaddons/src/util/qiconoverlay.h

Re: Review Request 112079: Add utility function to paint icon overlays

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/#review38045 --- staging/kguiaddons/src/util/qiconoverlay.h

Re: Review Request 112079: Add utility function to paint icon overlays

> On Aug. 14, 2013, 5:40 p.m., Aurélien Gâteau wrote: > > Forgot one thing: file names should be renamed to not start with "q". Maybe > > kiconoverlay.*? > > Martin Klapetek wrote: > Yeah I wasn't really sure about the name, but I didn't want to name it > "kiconoverlay" as there is no kico

Re: Review Request 112079: Add utility function to paint icon overlays

> On Aug. 14, 2013, 5 p.m., Aurélien Gâteau wrote: > > staging/kguiaddons/src/util/qiconoverlay.cpp, line 26 > > > > > > Qt doc says you should inherit from QIconEngineV2 instead > > Martin Klapetek wrote: > T

Re: Review Request 112079: Add utility function to paint icon overlays

> On Aug. 14, 2013, 3:40 p.m., Aurélien Gâteau wrote: > > Forgot one thing: file names should be renamed to not start with "q". Maybe > > kiconoverlay.*? Yeah I wasn't really sure about the name, but I didn't want to name it "kiconoverlay" as there is no kicon (and it puts overlay over qicon).

Re: Review Request 112079: Add utility function to paint icon overlays

> On Aug. 14, 2013, 3 p.m., Aurélien Gâteau wrote: > > staging/kguiaddons/src/util/qiconoverlay.h, line 29 > > > > > > Since the methods are in a KIconUtils namespace, maybe their name can > > be simplified to "ad

Re: Review Request 112079: Add utility function to paint icon overlays

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/#review37774 --- Forgot one thing: file names should be renamed to not start wit

Re: Review Request 112079: Add utility function to paint icon overlays

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/#review37765 --- staging/kguiaddons/src/util/qiconoverlay.h

Review Request 112079: Add utility function to paint icon overlays

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/ --- Review request for KDE Frameworks. Description --- As this was reject