Re: Review Request 112051: port kconfig_compiler from QApplication to QGuiApplication

2013-08-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112051/ --- (Updated Aug. 19, 2013, 10:37 a.m.) Status -- This change has been ma

Re: Review Request 112051: port kconfig_compiler from QApplication to QGuiApplication

2013-08-19 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112051/#review38108 --- Ship it! Ship It! - Kevin Ottens On Aug. 13, 2013, 11:06 a.

Re: Review Request 112051: port kconfig_compiler from QApplication to QGuiApplication

2013-08-19 Thread Kevin Ottens
> On Aug. 13, 2013, 11:08 a.m., Albert Astals Cid wrote: > > Can it maybe even be a QCoreApplication? > > Wojciech Kapuscinski wrote: > Probably yes :) Kevin? Quite some of those tests refer to QIcon and QColor, so QGuiApplication makes more sense. - Kevin -

Re: Review Request 112051: port kconfig_compiler from QApplication to QGuiApplication

2013-08-13 Thread Wojciech Kapuscinski
> On Aug. 13, 2013, 11:08 a.m., Albert Astals Cid wrote: > > Can it maybe even be a QCoreApplication? Probably yes :) Kevin? - Wojciech --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112

Re: Review Request 112051: port kconfig_compiler from QApplication to QGuiApplication

2013-08-13 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112051/#review37676 --- Can it maybe even be a QCoreApplication? - Albert Astals Cid

Re: Review Request 112051: port kconfig_compiler from QApplication to QGuiApplication

2013-08-13 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112051/ --- (Updated Aug. 13, 2013, 11:06 a.m.) Review request for KDE Frameworks. D

Review Request 112051: port kconfig_compiler from QApplication to QGuiApplication

2013-08-13 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112051/ --- Review request for KDE Frameworks. Description --- port kconfig_compi