Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-20 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/ --- (Updated Aug. 20, 2013, 1:21 p.m.) Status -- This change has been mar

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-20 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/#review38182 --- Ship it! Ship It! - Kevin Ottens On Aug. 19, 2013, 10:43 a.

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-19 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/ --- (Updated Aug. 19, 2013, 10:43 a.m.) Review request for KDE Frameworks. D

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-19 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/#review38122 --- kio/kfile/kurlrequester.cpp

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-19 Thread Kevin Ottens
> On Aug. 13, 2013, 7:25 a.m., Kevin Ottens wrote: > > kfile/kdirselectdialog.cpp, line 408 > > > > > > Hmmm it makes me realize, couldn't KEncodingFileDialog be made to > > depend on the file module only? That w

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-15 Thread Andrius da Costa Ribas
> On Aug. 13, 2013, 7:25 a.m., Kevin Ottens wrote: > > Small question: by replacing KFileDialog by QFileDialog do we still provide the settings to choose whether to use Native or KDE dialog on Windows? I use the KDE one here because of the places panel where I have lots of SFTP/FTP/SMB places

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-15 Thread Teo Mrnjavac
> On Aug. 13, 2013, 7:25 a.m., Kevin Ottens wrote: > > kfile/kdirselectdialog.cpp, line 408 > > > > > > Hmmm it makes me realize, couldn't KEncodingFileDialog be made to > > depend on the file module only? That w

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-15 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/ --- (Updated Aug. 15, 2013, 3:36 p.m.) Review request for KDE Frameworks. De

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/#review37766 --- kio/kfile/kurlrequester.h

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-14 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/ --- (Updated Aug. 14, 2013, 12:20 p.m.) Review request for KDE Frameworks. D

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-13 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/#review37641 --- kfile/kdirselectdialog.cpp

Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-12 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/ --- Review request for KDE Frameworks. Description --- KFileDialog is dep