Re: Review Request 111877: desktop_to_json cmake macro

2013-08-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111877/#review37418 --- This review has been submitted with commit 7dd76b3aa7c5dc12d8f

Re: Review Request 111877: desktop_to_json cmake macro

2013-08-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111877/ --- (Updated Aug. 9, 2013, 1:07 p.m.) Status -- This change has been mark

Re: Review Request 111877: desktop_to_json cmake macro

2013-08-09 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111877/#review37409 --- Ship it! Ship It! - Kevin Ottens On Aug. 8, 2013, 10:26 p.m

Re: Review Request 111877: desktop_to_json cmake macro

2013-08-08 Thread Sebastian Kügler
> On Aug. 8, 2013, 3:18 p.m., Kevin Ottens wrote: > > staging/kservice/KServiceMacros.cmake, line 33 > > > > > > Typo, should be ".json" and not "Json" I think. This is just for sanitizing the target, not for the

Re: Review Request 111877: desktop_to_json cmake macro

2013-08-08 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111877/ --- (Updated Aug. 8, 2013, 10:26 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 111877: desktop_to_json cmake macro

2013-08-08 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111877/#review37351 --- staging/kservice/KServiceMacros.cmake

Review Request 111877: desktop_to_json cmake macro

2013-08-03 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111877/ --- Review request for KDE Frameworks. Description --- This patch adds a