Re: Review Request 111492: rename kservice framework lib to KService

2013-07-13 Thread Benjamin Port
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111492/ --- (Updated July 13, 2013, 3:52 p.m.) Status -- This change has been mar

Re: Review Request 111492: rename kservice framework lib to KService

2013-07-13 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111492/#review35912 --- Ship it! Also see my comment on: https://git.reviewboard.kde.o

Re: Review Request 111492: rename kservice framework lib to KService

2013-07-13 Thread Benjamin Port
> On July 12, 2013, 8:10 p.m., Alexander Neundorf wrote: > > Looks ok. > > You are creating a separate Targets.cmake file now. Does that already work, > > i.e. kservice does not link against any kdelibs (except tier1/ and tier2/) > > libraries anymore ? > > > > And as for kde4support, while yo

Re: Review Request 111492: rename kservice framework lib to KService

2013-07-12 Thread Benjamin Port
> On July 12, 2013, 8:10 p.m., Alexander Neundorf wrote: > > Looks ok. > > You are creating a separate Targets.cmake file now. Does that already work, > > i.e. kservice does not link against any kdelibs (except tier1/ and tier2/) > > libraries anymore ? > > > > And as for kde4support, while yo

Re: Review Request 111492: rename kservice framework lib to KService

2013-07-12 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111492/#review35903 --- Looks ok. You are creating a separate Targets.cmake file now. D

Review Request 111492: rename kservice framework lib to KService

2013-07-12 Thread Benjamin Port
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111492/ --- Review request for KDE Frameworks. Description --- In order to have a