Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-13 Thread Sebastian Kügler
On Friday, July 12, 2013 21:36:15 Commit Hook wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111210/ > --- > > (Updated Jul

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/#review35906 --- This review has been submitted with commit 4f58afffc642742ed48

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 12, 2013, 9:36 p.m.) Status -- This change has been mar

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/#review35893 --- The kxmlgui_unittest crash is due to more Q_D/Q_DECLARE_PRIVATE

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-10 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 10, 2013, 8:44 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-10 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 10, 2013, 11:48 a.m.) Review request for KDE Frameworks. D

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-10 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 10, 2013, 10:08 a.m.) Review request for KDE Frameworks. D

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-09 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 10, 2013, 8:53 a.m.) Review request for KDE Frameworks. De

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/#review35805 --- kdeui/dialogs/kbugreport.cpp

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-09 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 9, 2013, 1:07 p.m.) Review request for KDE Frameworks. Des

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-07 Thread David Faure
> On July 5, 2013, 4:03 p.m., David Faure wrote: > > OK, so now it builds. Next step, fixing the crashes. > > > > You gave me an interesting time with that one, but I found it: > > > > KMainWindow has a member caller k_ptr (for KMainWindowPrivate), but you > > ported from the local K_D macro (

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-06 Thread Andrea Scarpino
> On July 5, 2013, 6:03 p.m., David Faure wrote: > > OK, so now it builds. Next step, fixing the crashes. > > > > You gave me an interesting time with that one, but I found it: > > > > KMainWindow has a member caller k_ptr (for KMainWindowPrivate), but you > > ported from the local K_D macro (

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/#review35640 --- OK, so now it builds. Next step, fixing the crashes. You gave

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-05 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 5, 2013, 3:27 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-05 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 5, 2013, 2:57 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-05 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 5, 2013, 12:28 p.m.) Review request for KDE Frameworks. De

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-05 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 5, 2013, 12:16 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-04 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 4, 2013, 5:22 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-03 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 3, 2013, 3:59 p.m.) Review request for KDE Frameworks. Cha