Re: Review Request 110988: Port kio-file to QFile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review36249 --- This review has been submitted with commit 7820c986664827907e2

Re: Review Request 110988: Port kio-file to QFile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review36248 --- This review has been submitted with commit e6eaeb9b28d21414581

Re: Review Request 110988: Port kio-file to QFile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review35834 --- This review has been submitted with commit 977d43a86fc9d0f8bf1

Re: Review Request 110988: Port kio-file to QFile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/ --- (Updated July 10, 2013, 10:41 a.m.) Status -- This change has been ma

Re: Review Request 110988: Port kio-file to QFile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review35835 --- This review has been submitted with commit bd12932aaf7fcb191cf

Re: Review Request 110988: Port kio-file to QFile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review35833 --- Ship it! kioslave/file/file.cpp

Re: Review Request 110988: Port kio-file to QFile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/ --- (Updated July 10, 2013, 9:55 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 110988: Port kio-file to QFile

> On July 9, 2013, 9:39 p.m., David Faure wrote: > > kioslave/file/file.cpp, line 476 > > > > > > coding style: no spaces inside parenthesis (same in a few other places). > > Martin Klapetek wrote: > Fwiw, th

Re: Review Request 110988: Port kio-file to QFile

> On July 9, 2013, 9:39 p.m., David Faure wrote: > > kioslave/file/file.cpp, line 476 > > > > > > coding style: no spaces inside parenthesis (same in a few other places). > > Martin Klapetek wrote: > Fwiw, th

Re: Review Request 110988: Port kio-file to QFile

> On July 9, 2013, 9:39 p.m., David Faure wrote: > > kioslave/file/file.cpp, line 476 > > > > > > coding style: no spaces inside parenthesis (same in a few other places). > > Martin Klapetek wrote: > Fwiw, th

Re: Review Request 110988: Port kio-file to QFile

> On July 9, 2013, 9:39 p.m., David Faure wrote: > > kioslave/file/file.cpp, line 476 > > > > > > coding style: no spaces inside parenthesis (same in a few other places). > > Martin Klapetek wrote: > Fwiw, th

Re: Review Request 110988: Port kio-file to QFile

> On July 9, 2013, 9:39 p.m., David Faure wrote: > > kioslave/file/file.cpp, line 476 > > > > > > coding style: no spaces inside parenthesis (same in a few other places). Fwiw, the coding style in this file is mo

Re: Review Request 110988: Port kio-file to QFile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review35814 --- Ship it! OK, so let's get this in then. About file_unix.cpp:

Re: Review Request 110988: Port kio-file to QFile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/ --- (Updated July 9, 2013, 9:26 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 110988: Port kio-file to QFile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/ --- (Updated July 9, 2013, 9:19 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 110988: Port kio-file to QFile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review35777 --- kioslave/file/file.cpp

Re: Review Request 110988: Port kio-file to QFile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review35768 --- kioslave/file/file.cpp

Re: Review Request 110988: Port kio-file to QFile

> On July 3, 2013, 11:07 a.m., David Faure wrote: > > Did you follow the instructions on > > http://community.kde.org/Frameworks/Building#Running_unit_tests ? > > > > You need a separate dbus session and you need to run kdeinit5 by hand, > > before you can run tests that use kioslaves. > > And

Re: Review Request 110988: Port kio-file to QFile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review35503 --- Did you follow the instructions on http://community.kde.org/Fr

Re: Review Request 110988: Port kio-file to QFile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/ --- (Updated June 25, 2013, 8:08 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 110988: Port kio-file to QFile

> On June 21, 2013, 7:44 a.m., David Faure wrote: > > Did you upload the same patch as before? The issues are still there (e.g. > > if (!write)) > > Martin Klapetek wrote: > I haven't updated it yet, will do so today. > > Kevin Ottens wrote: > Today as in three days ago? ;) Fwiw, I wa

Re: Review Request 110988: Port kio-file to QFile

> On June 21, 2013, 7:44 a.m., David Faure wrote: > > Did you upload the same patch as before? The issues are still there (e.g. > > if (!write)) > > Martin Klapetek wrote: > I haven't updated it yet, will do so today. Today as in three days ago? ;) - Kevin -

Re: Review Request 110988: Port kio-file to QFile

> On June 21, 2013, 7:44 a.m., David Faure wrote: > > Did you upload the same patch as before? The issues are still there (e.g. > > if (!write)) I haven't updated it yet, will do so today. - Martin --- This is an automatically generate

Re: Review Request 110988: Port kio-file to QFile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review34807 --- Did you upload the same patch as before? The issues are still t

Re: Review Request 110988: Port kio-file to QFile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review34736 --- kioslave/file/file.cpp

Re: Review Request 110988: Port kio-file to QFile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review34671 --- kioslave/file/file.cpp

Re: Review Request 110988: Port kio-file to QFile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/ --- (Updated June 19, 2013, 1:04 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 110988: Port kio-file to QFile

> On June 13, 2013, 11:06 a.m., David Faure wrote: > > kioslave/file/file.cpp, line 453 > > > > > > Bug in the original code? Should be ..._FOR_WRITING if mode & > > QIODevice::WriteOnly? > > Martin Klapetek wro

Re: Review Request 110988: Port kio-file to QFile

> On June 13, 2013, 11:06 a.m., David Faure wrote: > > Good work, not an easy task. > > > > In addition to the issues I found, could you ensure that the unittests > > still pass? In particular jobtest in kio, looks appropriate. Plus the one > > that calls chmod(). Will do. > On June 13, 201

Re: Review Request 110988: Port kio-file to QFile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review34280 --- Good work, not an easy task. In addition to the issues I found

Review Request 110988: Port kio-file to QFile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/ --- Review request for KDE Frameworks. Description --- Ports away kioslav