Re: Review Request 110858: Cleanup KDE development scripts

2013-07-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110858/ --- (Updated July 5, 2013, 7:53 a.m.) Status -- This change has been mark

Re: Review Request 110858: Cleanup KDE development scripts

2013-07-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110858/#review35614 --- This review has been submitted with commit 002eac6f43489b8e3c1

Re: Review Request 110858: Cleanup KDE development scripts

2013-07-04 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110858/ --- (Updated July 5, 2013, 3:01 a.m.) Review request for KDE Frameworks and Da

Re: Review Request 110858: Cleanup KDE development scripts

2013-07-04 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110858/ --- (Updated July 5, 2013, 2:36 a.m.) Review request for KDE Frameworks and Da

Re: Review Request 110858: Cleanup KDE development scripts

2013-07-04 Thread Vadim Zhukov
> On July 4, 2013, 4:03 p.m., David Faure wrote: > > Looks good. Please commit, after fixing the two small things I found. If > > you don't have an account, please tell me and I'll push the changes. Yes, I don't have commit access, so I cannot push the changes myself. - Vadim --

Re: Review Request 110858: Cleanup KDE development scripts

2013-07-04 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110858/ --- (Updated July 4, 2013, 7:26 p.m.) Review request for KDE Frameworks and Da

Re: Review Request 110858: Cleanup KDE development scripts

2013-07-04 Thread Vadim Zhukov
> On July 4, 2013, 4:03 p.m., David Faure wrote: > > makeobj, line 208 > > > > > > messed up indentation Actually, the indentation is not consistent through this file (not ever talking about cross-script consist

Re: Review Request 110858: Cleanup KDE development scripts

2013-07-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110858/#review35560 --- Ship it! Looks good. Please commit, after fixing the two small

Re: Review Request 110858: Cleanup KDE development scripts

2013-07-03 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110858/ --- (Updated July 4, 2013, 2:05 a.m.) Review request for KDE Frameworks and Da

Re: Review Request 110858: Cleanup KDE development scripts

2013-07-03 Thread Vadim Zhukov
> On June 11, 2013, 7:43 p.m., David Faure wrote: > > build-progress.sh, line 16 > > > > > > I thought grep -r wasn't portable? > > Vadim Zhukov wrote: > Yep, this should be "-R", of course. Many grep(1) imple

Re: Review Request 110858: Cleanup KDE development scripts

2013-06-24 Thread Vadim Zhukov
> On June 11, 2013, 7:43 p.m., David Faure wrote: > > build-progress.sh, line 16 > > > > > > I thought grep -r wasn't portable? Yep, this should be "-R", of course. Many grep(1) implementations still accept "-r",

Re: Review Request 110858: Cleanup KDE development scripts

2013-06-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110858/#review34151 --- The perl stuff looks mostly ok, but I found some issues that wo

Re: Review Request 110858: Cleanup KDE development scripts

2013-06-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110858/ --- (Updated June 6, 2013, 11:44 p.m.) Review request for KDE Frameworks and D