Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

> On June 5, 2013, 9:08 p.m., David Faure wrote: > > staging/knotifications/src/CMakeLists.txt, line 31 > > > > > > Is that .h.cmake file missing? I don't see it in git, and it's not in > > this review request eit

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/ --- (Updated June 6, 2013, 11:47 a.m.) Status -- This change has been mar

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/#review33825 --- Ship it! staging/knotifications/src/CMakeLists.txt

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

> On June 4, 2013, 10:52 p.m., David Faure wrote: > > staging/knotifications/src/knotificationrestrictions.h, line 23 > > > > > > wrong file sorry, uploaded the wrong diff yesterday - Marco ---

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/ --- (Updated June 5, 2013, 7:39 p.m.) Review request for KDE Frameworks. Des

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/#review33775 --- staging/knotifications/src/knotificationrestrictions.h

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/ --- (Updated June 4, 2013, 8:02 p.m.) Review request for KDE Frameworks. Des

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

> On May 29, 2013, 4:02 p.m., David Faure wrote: > > staging/knotifications/src/kstatusnotifieritem.cpp, line 42 > > > > > > doesn't look portable to Windows? > > Marco Martin wrote: > what would be a way to m

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

> On May 29, 2013, 4:02 p.m., David Faure wrote: > > staging/knotifications/src/kstatusnotifieritem.cpp, line 42 > > > > > > doesn't look portable to Windows? what would be a way to make it portable? it's basicall

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/ --- (Updated June 3, 2013, 7:29 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/#review33367 --- the description is slightly wrong now: the test doesn't need kd

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/ --- (Updated May 28, 2013, 7:11 p.m.) Review request for KDE Frameworks. Des

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/#review33289 --- staging/knotifications/src/knotificationrestrictions.h

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/ --- (Updated May 21, 2013, 7:49 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/ --- (Updated May 21, 2013, 7:43 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/#review32897 --- staging/knotifications/src/CMakeLists.txt

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

> On May 21, 2013, 10:46 a.m., Kevin Ottens wrote: > > I think it's taking the right direction. Probably good to get rid of ki18n > > if we don't use any of its advanced features (I don't think we do). As for > > kwidgets and kwidgetsaddons, it depends a bit on the aim we have for that > > lib

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/ --- (Updated May 21, 2013, 12:45 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

> On May 21, 2013, 10:46 a.m., Kevin Ottens wrote: > > I think it's taking the right direction. Probably good to get rid of ki18n > > if we don't use any of its advanced features (I don't think we do). As for > > kwidgets and kwidgetsaddons, it depends a bit on the aim we have for that > > lib

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

> On May 21, 2013, 10:46 a.m., Kevin Ottens wrote: > > I think it's taking the right direction. Probably good to get rid of ki18n > > if we don't use any of its advanced features (I don't think we do). As for > > kwidgets and kwidgetsaddons, it depends a bit on the aim we have for that > > lib

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/#review32879 --- I think it's taking the right direction. Probably good to get r

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/ --- (Updated May 18, 2013, 3:27 p.m.) Review request for KDE Frameworks. Des

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/ --- (Updated May 18, 2013, 3:27 p.m.) Review request for KDE Frameworks. Des