Re: Review Request 109524: Remove some compile warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109524/ --- (Updated June 3, 2013, 8:08 p.m.) Status -- This change has been mark

Re: Review Request 109524: Remove some compile warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109524/#review33695 --- This review has been submitted with commit 8ad8d7239efc502fe99

Re: Review Request 109524: Remove some compile warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109524/#review33537 --- Ship it! Ship It! - David Faure On May 31, 2013, 8:01 p.m.,

Re: Review Request 109524: Remove some compile warnings

> On May 6, 2013, 12:08 p.m., Kevin Ottens wrote: > > Miquel, any news? Anything blocking you to make a new revision of that > > patch? Sorry for delay. I need to update and build Qt dev again. I'm going to update it tomorrow. - Miquel --

Re: Review Request 109524: Remove some compile warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109524/ --- (Updated May 31, 2013, 8:01 p.m.) Review request for KDE Frameworks and Al

Re: Review Request 109524: Remove some compile warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109524/#review32132 --- Miquel, any news? Anything blocking you to make a new revision

Re: Review Request 109524: Remove some compile warnings

> On April 8, 2013, 6:30 p.m., David Faure wrote: > > staging/ki18n/src/klocalizedstring.cpp, line 1349 > > > > > > This one looks like a bug to me. Just ignoging plural handling sounds > > like a bug... > > Mi

Re: Review Request 109524: Remove some compile warnings

> On April 9, 2013, 6:10 a.m., Kevin Ottens wrote: > > kdeui/tests/kreplacetest.cpp, line 57 > > > > > > In fact I'm not sure I get this one... It's fine for the slot to have > > only a QString (I see you introd

Re: Review Request 109524: Remove some compile warnings

> On April 9, 2013, 6:10 a.m., Kevin Ottens wrote: > > kdeui/tests/kreplacetest.cpp, line 57 > > > > > > In fact I'm not sure I get this one... It's fine for the slot to have > > only a QString (I see you introd

Re: Review Request 109524: Remove some compile warnings

> On April 8, 2013, 6:30 p.m., David Faure wrote: > > staging/ki18n/src/klocalizedstring.cpp, line 1349 > > > > > > This one looks like a bug to me. Just ignoging plural handling sounds > > like a bug... It's o

Re: Review Request 109524: Remove some compile warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109524/#review30735 --- kdeui/tests/kreplacetest.cpp

Re: Review Request 109524: Remove some compile warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109524/#review30713 --- Looks good, although I wouldn't comment out the one in klocaliz

Re: Review Request 109524: Remove some compile warnings

> On March 16, 2013, 7:22 p.m., Stephen Kelly wrote: > > tier1/kcodecs/autotests/kcharsetstest.cpp, line 135 > > > > > > Warnings are sometimes valid and create a todo list. Changes like this > > look like just h

Re: Review Request 109524: Remove some compile warnings

> On March 16, 2013, 7:22 p.m., Stephen Kelly wrote: > > tier1/kcodecs/autotests/kcharsetstest.cpp, line 135 > > > > > > Warnings are sometimes valid and create a todo list. Changes like this > > look like just h

Re: Review Request 109524: Remove some compile warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109524/ --- (Updated April 7, 2013, 10:26 p.m.) Review request for KDE Frameworks and

Re: Review Request 109524: Remove some compile warnings

> On March 16, 2013, 7:22 p.m., Stephen Kelly wrote: > > tier1/kcodecs/autotests/kcharsetstest.cpp, line 135 > > > > > > Warnings are sometimes valid and create a todo list. Changes like this > > look like just h

Re: Review Request 109524: Remove some compile warnings

> On March 16, 2013, 7:22 p.m., Stephen Kelly wrote: > > tier1/itemmodels/src/kselectionproxymodel.cpp, line 2148 > > > > > > Why do you remove this? > > Miquel Canes Gonzalez wrote: > This assert checks if

Re: Review Request 109524: Remove some compile warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109524/#review29431 --- kdeui/tests/kreplacetest.cpp

Re: Review Request 109524: Remove some compile warnings

> On March 16, 2013, 7:22 p.m., Stephen Kelly wrote: > > tier1/itemmodels/src/kselectionproxymodel.cpp, line 2148 > > > > > > Why do you remove this? This assert checks if a pointer is not negative. Why we want

Re: Review Request 109524: Remove some compile warnings

> On March 16, 2013, 8:57 p.m., David Faure wrote: > > That's right. I'm going to fix. - Miquel --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109524/#review29336 ---

Re: Review Request 109524: Remove some compile warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109524/#review29336 --- kdecore/io/kdebug.cpp

Re: Review Request 109524: Remove some compile warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109524/#review29333 --- tier1/itemmodels/src/kselectionproxymodel.cpp

Re: Review Request 109524: Remove some compile warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109524/ --- (Updated March 16, 2013, 6:16 p.m.) Review request for KDE Frameworks and