Re: Review Request 109480: Add support for xcb_generic_event_t to KKeyServer::xEventToQt

2013-07-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109480/ --- (Updated July 29, 2013, 6:55 a.m.) Status -- This change has been mar

Re: Review Request 109480: Add support for xcb_generic_event_t to KKeyServer::xEventToQt

2013-07-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109480/#review36701 --- This review has been submitted with commit 373d812a636da898a0f

Re: Review Request 109480: Add support for xcb_generic_event_t to KKeyServer::xEventToQt

2013-07-27 Thread Martin Gräßlin
> On July 27, 2013, 9:52 a.m., David Faure wrote: > > tier1/kwindowsystem/src/kkeyserver_x11.h, line 170 > > > > > > The double semicolon isn't really useful :) I need to fix my kdevelop - that's the second time

Re: Review Request 109480: Add support for xcb_generic_event_t to KKeyServer::xEventToQt

2013-07-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109480/#review36578 --- Ship it! Looks good, just two small comments. tier1/kwindows

Re: Review Request 109480: Add support for xcb_generic_event_t to KKeyServer::xEventToQt

2013-07-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109480/ --- (Updated July 26, 2013, 9:49 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 109480: Add support for xcb_generic_event_t to KKeyServer::xEventToQt

2013-05-06 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109480/#review32129 --- Martin, any news about that patch? It would be nice to see the

Re: Review Request 109480: Add support for xcb_generic_event_t to KKeyServer::xEventToQt

2013-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109480/#review29752 --- kdeui/util/kkeyserver_x11.h

Review Request 109480: Add support for xcb_generic_event_t to KKeyServer::xEventToQt

2013-03-14 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109480/ --- Review request for KDE Frameworks. Description --- Allows converting