Re: Review Request: Remove QFSFileEngine useage from Phonon five.

2012-10-21 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106974/ --- (Updated Oct. 21, 2012, 2 p.m.) Review request for KDE Frameworks and Phon

Re: Review Request: Remove QFSFileEngine useage from Phonon five.

2012-10-21 Thread Harald Sitter
> On Oct. 21, 2012, 10:30 a.m., Harald Sitter wrote: > > phonon/mediasource.cpp, line 58 > > > > > > documentation on why path and url would be useful > > Jon Severinsson wrote: > I thought it self explanatory,

Re: Review Request: Remove QFSFileEngine useage from Phonon five.

2012-10-21 Thread Jon Severinsson
> On Oct. 21, 2012, 10:46 a.m., David Faure wrote: > > Urgh, too much detailed magic. > > > > Either the input string is always a local path, and use fromLocalFile. Or > > it's always a URL, and use QUrl(QString). Or it could be either one, and > > then QUrl::fromUserInput(QString) is what you

Re: Review Request: Remove QFSFileEngine useage from Phonon five.

2012-10-21 Thread David Faure
> On Oct. 21, 2012, 10:46 a.m., David Faure wrote: > > Urgh, too much detailed magic. > > > > Either the input string is always a local path, and use fromLocalFile. Or > > it's always a URL, and use QUrl(QString). Or it could be either one, and > > then QUrl::fromUserInput(QString) is what you

Re: Review Request: Remove QFSFileEngine useage from Phonon five.

2012-10-21 Thread Jon Severinsson
> On Oct. 21, 2012, 10:46 a.m., David Faure wrote: > > Urgh, too much detailed magic. > > > > Either the input string is always a local path, and use fromLocalFile. Or > > it's always a URL, and use QUrl(QString). Or it could be either one, and > > then QUrl::fromUserInput(QString) is what you

Re: Review Request: Remove QFSFileEngine useage from Phonon five.

2012-10-21 Thread Jon Severinsson
> On Oct. 21, 2012, 10:30 a.m., Harald Sitter wrote: > > Changing the behavior of a function to that extent seems unwise to me, plus > > it allows even further misuse of the function. One should only ever have > > local files thrown at that function, hence why I think Phonon 5 should not > > h

Re: Review Request: Remove QFSFileEngine useage from Phonon five.

2012-10-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106974/#review20619 --- Urgh, too much detailed magic. Either the input string is alwa

Re: Review Request: Remove QFSFileEngine useage from Phonon five.

2012-10-21 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106974/#review20616 --- Changing the behavior of a function to that extent seems unwise

Re: Review Request: Remove QFSFileEngine useage from Phonon five.

2012-10-21 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106974/ --- (Updated Oct. 21, 2012, 9:59 a.m.) Review request for KDE Frameworks and P

Re: Review Request: Remove QFSFileEngine useage from Phonon five.

2012-10-20 Thread Harald Sitter
> On Oct. 20, 2012, 8:23 p.m., David Faure wrote: > > kcoreaddons has KFileSystemType, to distinguish local from NFS/SMB (which I > > guess this is what this was about). > > Maybe it could go into Qt I guess for now this is ok (unless we want to > > use kcoreaddons in phonon, but I doubt th

Re: Review Request: Remove QFSFileEngine useage from Phonon five.

2012-10-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106974/#review20604 --- kcoreaddons has KFileSystemType, to distinguish local from NFS/

Review Request: Remove QFSFileEngine useage from Phonon five.

2012-10-20 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106974/ --- Review request for KDE Frameworks and Phonon. Description --- QFSFile