Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests. Remove KAboutData where no longer needed.

2012-08-10 Thread Jeremy Paul Whiting
> On Aug. 10, 2012, 8:23 a.m., David Faure wrote: > > > > Jeremy Paul Whiting wrote: > How do I run just one test? just execute the .shell file? If so I get > the following: > > [jeremy@sonic tests]$ ./kmainwindow_unittest.shell > > /home/jeremy/devel/kde/src/kf5/kdelibs/bu

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests. Remove KAboutData where no longer needed.

2012-08-10 Thread David Faure
On Friday 10 August 2012 14:52:01 Jeremy Paul Whiting wrote: > > On Aug. 10, 2012, 8:23 a.m., David Faure wrote: > How do I run just one test? just execute the .shell file? If so I get the > following: > > [jeremy@sonic tests]$ ./kmainwindow_unittest.shell > /home/jeremy/devel/kde/src/kf5/kdelib

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests. Remove KAboutData where no longer needed.

2012-08-10 Thread Jeremy Paul Whiting
> On Aug. 10, 2012, 8:23 a.m., David Faure wrote: > > How do I run just one test? just execute the .shell file? If so I get the following: [jeremy@sonic tests]$ ./kmainwindow_unittest.shell /home/jeremy/devel/kde/src/kf5/kdelibs/build/kdeui/tests/kmainwindow_unittest: symbol lookup error:

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests. Remove KAboutData where no longer needed.

2012-08-10 Thread David Faure
On Friday 10 August 2012 08:23:29 David Faure wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105955/#review17178 > --- > >

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests. Remove KAboutData where no longer needed.

2012-08-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105955/#review17178 --- - David Faure On Aug. 10, 2012, 3 a.m., Jeremy Paul Whiting w

Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests. Remove KAboutData where no longer needed.

2012-08-09 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105955/ --- Review request for KDE Frameworks. Description --- Port from KApplica

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests.

2012-08-07 Thread Stephen Kelly
Jeremy Paul Whiting wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105897/ > --- > > (Updated Aug. 6, 2012, 6:53 p.m.) >

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests.

2012-08-06 Thread David Faure
On Monday 06 August 2012 13:53:08 Jeremy Whiting wrote: > I didn't check the make test against the result you are getting on the main > branch, no. I'll remove the KAboutData from these and check that. Some of > these KAboutData have quite a bit in them, is it ok to nuke them? Don't nuke those t

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests.

2012-08-06 Thread Jeremy Whiting
I didn't check the make test against the result you are getting on the main branch, no. I'll remove the KAboutData from these and check that. Some of these KAboutData have quite a bit in them, is it ok to nuke them? I also found one KApplication usage in an io slave that's part of the patch, is

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests.

2012-08-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105897/#review16996 --- Thanks, a good start. BTW did you try running the tests afterw

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests.

2012-08-06 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105897/ --- (Updated Aug. 6, 2012, 6:53 p.m.) Review request for KDE Frameworks and Da