Re: Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

2012-11-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106970/#review22580 --- This review has been submitted with commit 7500c995162ac56dd62

Re: Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

2012-11-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106970/#review22394 --- Ship it! I'm not an ECM expert, but this looks good to me. I'd

Re: Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

2012-11-03 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106970/ --- (Updated Nov. 3, 2012, 8:26 a.m.) Review request for KDE Frameworks and Ph

Re: Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

2012-11-01 Thread Jon Severinsson
> On Oct. 31, 2012, 4:58 p.m., David Faure wrote: > > The circular dependency (due to libinqt5 being in kdelibs currently) will > > make building a bit harder though. Shouldn't ECM be fixed NOT to require > > libinqt5? > > Jon Severinsson wrote: > There is no circular dependency, as libinq

Re: Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

2012-10-31 Thread David Faure
> On Oct. 31, 2012, 4:58 p.m., David Faure wrote: > > The circular dependency (due to libinqt5 being in kdelibs currently) will > > make building a bit harder though. Shouldn't ECM be fixed NOT to require > > libinqt5? > > Jon Severinsson wrote: > There is no circular dependency, as libinq

Re: Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

2012-10-31 Thread Jon Severinsson
> On Oct. 31, 2012, 4:58 p.m., David Faure wrote: > > The circular dependency (due to libinqt5 being in kdelibs currently) will > > make building a bit harder though. Shouldn't ECM be fixed NOT to require > > libinqt5? There is no circular dependency, as libinqt5 does not depend on Phonon. The

Re: Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

2012-10-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106970/#review21251 --- The circular dependency (due to libinqt5 being in kdelibs curre

Re: Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

2012-10-31 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106970/#review21244 --- Over a week and still no comments. If no one objects in the nex

Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

2012-10-20 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106970/ --- Review request for KDE Frameworks and Phonon. Description --- This pa