Re: Review Request: Fix attica dependency

2012-12-26 Thread Valentin Rusu
> On Dec. 26, 2012, 9:12 a.m., Christophe Giboudeaux wrote: > > knewstuff/knewstuff3/CMakeLists.txt, line 21 > > > > > > endif() > > > > Please read > > http://techbase.kde.org/Policies/CMake_Coding_Style

Re: Review Request: Fix attica dependency

2012-12-26 Thread Christophe Giboudeaux
> On Dec. 26, 2012, 9:12 a.m., Christophe Giboudeaux wrote: > > knewstuff/knewstuff3/CMakeLists.txt, line 21 > > > > > > endif() > > > > Please read > > http://techbase.kde.org/Policies/CMake_Coding_Style

Re: Review Request: Fix attica dependency

2012-12-26 Thread Christophe Giboudeaux
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107911/#review23985 --- knewstuff/knewstuff3/CMakeLists.txt

Re: Review Request: Fix attica dependency

2012-12-26 Thread Valentin Rusu
> On Dec. 26, 2012, 9:12 a.m., Christophe Giboudeaux wrote: > > knewstuff/knewstuff3/CMakeLists.txt, line 21 > > > > > > endif() > > > > Please read > > http://techbase.kde.org/Policies/CMake_Coding_Style

Re: Review Request: Fix attica dependency

2012-12-26 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107911/ --- (Updated Dec. 26, 2012, 10:28 a.m.) Review request for KDE Frameworks and

Re: Review Request: Fix attica dependency

2012-12-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107911/#review23983 --- knewstuff/knewstuff3/CMakeLists.txt

Review Request: Fix attica dependency

2012-12-25 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107911/ --- Review request for KDE Frameworks and David Faure. Description --- Fo