Re: Minimum required cmake version

2017-01-03 Thread Sven Brauch
ghting) don't actually build with cmake 2.8 -- it seems to > be related with moc'ing the Q_GADGET macro. Still, they specify cmake > 2.8 as the minimum required cmake version. > > Do we > - attempt to fix this with cmake 2.8 > - bump the required cmake version to 3.0

Re: Minimum required cmake version

2017-01-03 Thread Sven Brauch
On 03/01/17 14:13, David Faure wrote: >> No objection. > > I do, however, have an objection to untested commits. > > Sven, your commits broke knewstuff and some other modules. > > CMake Error at /d/kde/inst/kde_frameworks/share/ECM/modules/ > ECMGeneratePriFile.cmake:137 (message): > Required

Re: Minimum required cmake version

2017-01-03 Thread Sven Brauch
Hey, On 03/01/17 14:13, David Faure wrote: > Sven, your commits broke knewstuff and some other modules. > > CMake Error at /d/kde/inst/kde_frameworks/share/ECM/modules/ > ECMGeneratePriFile.cmake:137 (message): > Required variable PROJECT_VERSION_STRING not set before > ECM_GENERATE_PRI_FILE(

Re: Minimum required cmake version

2017-01-03 Thread David Faure
On lundi 2 janvier 2017 10:43:37 CET David Faure wrote: > On lundi 2 janvier 2017 03:50:06 CET Aleix Pol wrote: > > On Sat, Dec 31, 2016 at 7:16 PM, Michael Pyne wrote: > > > On Sat, Dec 31, 2016 at 03:47:00PM +0100, Sven Brauch wrote: > > >> Hey, > > >> > > >> On 27/12/16 19:30, Aleix Pol wrote:

Re: Minimum required cmake version

2017-01-02 Thread David Faure
On lundi 2 janvier 2017 03:50:06 CET Aleix Pol wrote: > On Sat, Dec 31, 2016 at 7:16 PM, Michael Pyne wrote: > > On Sat, Dec 31, 2016 at 03:47:00PM +0100, Sven Brauch wrote: > >> Hey, > >> > >> On 27/12/16 19:30, Aleix Pol wrote: > >> > +1 on changing to 3.0. > >> > >> Thanks for your opinion on

Re: Minimum required cmake version

2017-01-01 Thread Aleix Pol
On Sat, Dec 31, 2016 at 7:16 PM, Michael Pyne wrote: > On Sat, Dec 31, 2016 at 03:47:00PM +0100, Sven Brauch wrote: >> Hey, >> >> On 27/12/16 19:30, Aleix Pol wrote: >> > +1 on changing to 3.0. >> Thanks for your opinion on the matter. I also think we should just bump >> it, 3.0 is old enough -- a

Re: Minimum required cmake version

2016-12-31 Thread Michael Pyne
On Sat, Dec 31, 2016 at 03:47:00PM +0100, Sven Brauch wrote: > Hey, > > On 27/12/16 19:30, Aleix Pol wrote: > > +1 on changing to 3.0. > Thanks for your opinion on the matter. I also think we should just bump > it, 3.0 is old enough -- as said it's even easily available on CentOS 6. > > Question

Re: Minimum required cmake version

2016-12-31 Thread Sven Brauch
Hey, On 27/12/16 19:30, Aleix Pol wrote: > +1 on changing to 3.0. Thanks for your opinion on the matter. I also think we should just bump it, 3.0 is old enough -- as said it's even easily available on CentOS 6. Question is, should I change it on _all_ frameworks or just those using Q_GADGET (i.e.

Re: Minimum required cmake version

2016-12-30 Thread Sune Vuorela
On 2016-12-27, Aleix Pol wrote: > Now everything makes sense, thanks! > > I confirm Q_GADGET is mentioned in cmake 3.0.0 codebase while it isn't > in 2.8.11. > +1 on changing to 3.0. As a datapoint, Debian stable has cmake 3.0 /Sune

Re: Minimum required cmake version

2016-12-27 Thread Aleix Pol
On Tue, Dec 27, 2016 at 7:25 PM, Sven Brauch wrote: > On 27/12/16 19:23, Aleix Pol wrote: >> Makes sense, although you still won't be able to compile these >> frameworks on CentOS 6.8 even if we fix that, right? > I have CMake 3.6 on CentOS 6.8, it's just called "camke3" instead of > "cmake". That

Re: Minimum required cmake version

2016-12-27 Thread Sven Brauch
On 27/12/16 19:23, Aleix Pol wrote: > Makes sense, although you still won't be able to compile these > frameworks on CentOS 6.8 even if we fix that, right? I have CMake 3.6 on CentOS 6.8, it's just called "camke3" instead of "cmake". That's why I was running cmake 2.8 so far, and noticed this issue

Re: Minimum required cmake version

2016-12-27 Thread Aleix Pol
On Tue, Dec 27, 2016 at 7:20 PM, Sven Brauch wrote: > Hi, > > On 27/12/16 19:18, Aleix Pol wrote: >> Have you checked that changing to cmake 3.0 actually solves this >> problem? > I have 3.6 on the same system and with that it works. I don't have 3.0. :/ > > However, 3.0 docs explicitly mentions Q

Re: Minimum required cmake version

2016-12-27 Thread Sven Brauch
Hi, On 27/12/16 19:18, Aleix Pol wrote: > Have you checked that changing to cmake 3.0 actually solves this > problem? I have 3.6 on the same system and with that it works. I don't have 3.0. :/ However, 3.0 docs explicitly mentions Q_GADGET. Greetings, Sven signature.asc Description: OpenPGP d

Re: Minimum required cmake version

2016-12-27 Thread Aleix Pol
make > 2.8 as the minimum required cmake version. > > Do we > - attempt to fix this with cmake 2.8 > - bump the required cmake version to 3.0 for these frameworks > - bump the required cmake version to 3.0 for all frameworks? > > Greetings, > Sven Hi Sven, Have you che

Minimum required cmake version

2016-12-27 Thread Sven Brauch
Hi, building on CentOS 6.8, I noticed some frameworks (namely KAuth, KSyntaxHighlighting) don't actually build with cmake 2.8 -- it seems to be related with moc'ing the Q_GADGET macro. Still, they specify cmake 2.8 as the minimum required cmake version. Do we - attempt to fix this