Re: Review Request 111927: remove K_EXPORT_PLUGIN macro

2013-08-07 Thread Commit Hook
rd.kde.org/r/111927/ > --- > > (Updated Aug. 7, 2013, 12:37 a.m.) > > > Review request for KDE Frameworks. > > > Description > --- > > Remove K_EXPORT_PLUGIN throughout. > > The recent chang

Re: Review Request 111927: remove K_EXPORT_PLUGIN macro

2013-08-07 Thread Commit Hook
marked as submitted. Review request for KDE Frameworks. Description --- Remove K_EXPORT_PLUGIN throughout. The recent changes to the K_PLUGIN_FACTORY macro make this unnecessary. The macro is in fact already a no-op. I have this branch split out in patches per module. Diffs

Re: Review Request 111927: remove K_EXPORT_PLUGIN macro

2013-08-07 Thread David Faure
g. 7, 2013, 12:37 a.m.) > > > Review request for KDE Frameworks. > > > Description > --- > > Remove K_EXPORT_PLUGIN throughout. > > The recent changes to the K_PLUGIN_FACTORY macro make this unnecessary. The > macro is in fact already a no-op. I have this

Review Request 111927: remove K_EXPORT_PLUGIN macro

2013-08-06 Thread Sebastian Kügler
K_EXPORT_PLUGIN throughout. The recent changes to the K_PLUGIN_FACTORY macro make this unnecessary. The macro is in fact already a no-op. I have this branch split out in patches per module. Diffs - interfaces/kmediaplayer/kfileaudiopreview/kfileaudiopreview.cpp b5b0f7b kfile/kfilemodule.cpp

Re: K_EXPORT_PLUGIN

2013-03-05 Thread Stephen Kelly
Aaron J. Seigo wrote: > On Tuesday, February 26, 2013 15:40:38 Aaron J. Seigo wrote: >> right now in libplasma2 we have definitions like this: > > anyone? :) > You might get a knowledgeable response on the Qt development mailing list. Thanks, Steve. _

Re: K_EXPORT_PLUGIN

2013-03-05 Thread Aaron J. Seigo
On Tuesday, February 26, 2013 15:40:38 Aaron J. Seigo wrote: > right now in libplasma2 we have definitions like this: anyone? :) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing lis

Re: K_EXPORT_PLUGIN

2013-02-26 Thread Aaron J. Seigo
PTENGINE(libname, classname) \ K_PLUGIN_FACTORY(factory, registerPlugin();) \ K_EXPORT_PLUGIN(factory("plasma_appletscriptengine_" #libname)) \ K_EXPORT_PLUGIN_VERSION(PLASMA_VERSION) then in a plugin: K_EXPORT_PLASMA_APPLETSCRIPTENGINE(declarativeappletscript, DeclarativeAppletScript)

Re: K_EXPORT_PLUGIN

2013-02-26 Thread Sebastian Kügler
On Monday, February 25, 2013 17:38:09 Aaron J. Seigo wrote: > in kexportplugin.h there is this: > > #pragma message("K_EXPORT_PLUGIN is defined as a hack here, for compat. Port > to new plugin system (QT_PLUGIN_METADATA) instead.") > > this was introduced in the

Re: K_EXPORT_PLUGIN

2013-02-26 Thread Martin Sandsmark
On Mon, Feb 25, 2013 at 05:38:09PM +0100, Aaron J. Seigo wrote: > can somene point me in a useful direction? thanks. http://qt-project.org/wiki/Transition_from_Qt_4.x_to_Qt5 -- Martin Sandsmark ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

K_EXPORT_PLUGIN

2013-02-25 Thread Aaron J. Seigo
hi ... in kexportplugin.h there is this: #pragma message("K_EXPORT_PLUGIN is defined as a hack here, for compat. Port to new plugin system (QT_PLUGIN_METADATA) instead.") this was introduced in the first revision of this file (58606a42). i haven't been able to find any use

Fwd: [kdelibs/frameworks] kdecore/util: This makes K_EXPORT_PLUGIN work with Qt5 again.

2012-08-06 Thread David Faure
-- Forwarded Message -- Subject: [kdelibs/frameworks] kdecore/util: This makes K_EXPORT_PLUGIN work with Qt5 again. Date: Monday 06 August 2012, 17:59:21 From: David Faure To: kde-comm...@kde.org CC: kde-framewo...@kde.org, thi...@kde.org Git commit