ason it isn't in KIO
>>> is that it depends on Phonon.
>>
>> KIO already depends indirectly on KNotifications which depends on Phonon.
>
> But maybe one day we'll have a notification framework in Qt, and then KIO
> won't depend on Phonon anymore :-)
>
nds on Phonon.
>
> KIO already depends indirectly on KNotifications which depends on Phonon.
But maybe one day we'll have a notification framework in Qt, and then KIO
won't depend on Phonon anymore :-)
Let's put KFileAudioPreview in kio-extras. KIO works perfectly well
On Monday 12 May 2014 22:46:08 Alex Merry wrote:
> KFileAudioPreview is currently a framework that just provides a plugin.
> This plugin is specifically looked for by the KFileMetaPreview class in KIO.
>
> Perhaps it's too late to change this, but it seems to me that this
>
On 12/05/14 23:18, Nicolás Alvarez wrote:
> 2014-05-12 18:46 GMT-03:00 Alex Merry :
>> Perhaps it's too late to change this, but it seems to me that this
>> plugin should either be in KIO or kio-extras. The reason it isn't in KIO
>> is that it depends on Phonon.
>
> KIO already depends indirectly
2014-05-12 18:46 GMT-03:00 Alex Merry :
> Perhaps it's too late to change this, but it seems to me that this
> plugin should either be in KIO or kio-extras. The reason it isn't in KIO
> is that it depends on Phonon.
KIO already depends indirectly on KNotifications which depends on Phonon.
--
Nic
KFileAudioPreview is currently a framework that just provides a plugin.
This plugin is specifically looked for by the KFileMetaPreview class in KIO.
Perhaps it's too late to change this, but it seems to me that this
plugin should either be in KIO or kio-extras. The reason it isn't in K
marked as submitted.
Review request for KDE Frameworks.
Repository: kfileaudiopreview
Description
---
Remove transitive dependencies. QtDBus is also not used.
Diffs
-
CMakeLists.txt 413d38c76d2d439f7cc99ac0b67193873458cde6
Diff: https://git.reviewboard.kde.org/r/115584/diff
org/r/115584/
> ---
>
> (Updated Feb. 8, 2014, 6:52 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kfileaudiopreview
>
>
> Description
> ---
>
> Remove transi
eb. 8, 2014, 6:52 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kfileaudiopreview
>
>
> Description
> ---
>
> Remove transitive dependencies. QtDBus is also not used.
>
>
> Diffs
> -
>
> CMakeLists.txt 413d38c76
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115584/
---
Review request for KDE Frameworks.
Repository: kfileaudiopreview
org/r/114129/
> ---
>
> (Updated Nov. 26, 2013, 12:44 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> ---
>
> Move kfileaudiopreview to
marked as submitted.
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
Move kfileaudiopreview to tier4
Diffs
-
staging/CMakeLists.txt 5b5cc2c7df4c3ca8b44bd25d1368e35a1fada4d9
staging/kfileaudiopreview/CMakeLists.txt
staging/kfileaudiopreview/README
. 26, 2013, 12:44 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> ---
>
> Move kfileaudiopreview to tier4
>
>
> Diffs
> -
>
> staging/CMakeLists.txt 5b5cc2c7df4c3ca8b44bd25d1
org/r/114037/
> ---
>
> (Updated Nov. 25, 2013, 3:33 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> ---
>
> Split kfileaudiopreview o
marked as submitted.
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
Split kfileaudiopreview out from kmediaplayer
Diffs
-
staging/kfileaudiopreview/CMakeLists.txt PRE-CREATION
staging/CMakeLists.txt 3ca6fbbb119c904ae2ef4682b424d7d68c1fddde
staging
org/r/114037/
> ---
>
> (Updated Nov. 22, 2013, 5:52 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> ---
>
> Split kfileaudiopreview o
v. 22, 2013, 5:52 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> ---
>
> Split kfileaudiopreview out from kmediaplayer
>
>
> Diffs
> -
>
> staging/kfileaudiopreview/CMakeLists.txt PRE-CR
---
Split kfileaudiopreview out from kmediaplayer
Diffs
-
staging/kfileaudiopreview/CMakeLists.txt PRE-CREATION
staging/CMakeLists.txt 3ca6fbbb119c904ae2ef4682b424d7d68c1fddde
staging/kfileaudiopreview/README PRE-CREATION
staging/kmediaplayer/CMakeLists.txt
discarded.
Review request for kde-workspace and KDE Frameworks.
Repository: kdelibs
Description
---
Remove kfileaudiopreview, as per discussion on IRC at last frameworks meeting.
I will add it to kde-workspace at the same time I push this.
Diffs
-
staging/kmediaplayer
. 20, 2013, 11:36 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> ---
>
> One last thing needed before I move this to kde-workspace:
>
>
> Make KFileAudioPreview use its own config group
>
&
---
One last thing needed before I move this to kde-workspace:
Make KFileAudioPreview use its own config group
Previously, it was using "KFileDialog Settings", and this string was
obtained from an internal KIO header (which breaks standalone builds).
Diffs
-
staging/kmedia
generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113883/
> ---
>
> (Updated Nov. 15, 2013, 9:10 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Descr
.
Changes
---
Change number to 5 instead of removing it.
Repository: kdelibs
Description
---
Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview
Diffs (updated)
-
staging/kmediaplayer/src/kfileaudiopreview/Messages.sh 71c7067
staging/kmediaplayer/src
--
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113883/
> ---
>
> (Updated Nov. 15, 2013, 1:22 p.m.)
>
>
> Review request for KDE Frameworks.
>
for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> ---
>
> Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview
>
>
> Diffs
> -----
>
> staging/kmediaplayer/src/kfileaudiopreview/Messages.sh
> 71c7067f3431c1d6d7
reply, visit:
> http://git.reviewboard.kde.org/r/113883/
> ---
>
> (Updated Nov. 15, 2013, 12:22 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> ---
>
> Rename translation
ov. 15, 2013, 12:22 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> ---
>
> Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview
>
>
> Diffs
> -
>
> staging/kmediaplay
.kde.org/r/113883/
> ---
>
> (Updated Nov. 15, 2013, 12:22 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> ---
>
> Rename translation catalogue kfileaudiopreview4 to kfileaudi
---
Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview
Diffs
-
staging/kmediaplayer/src/kfileaudiopreview/Messages.sh
71c7067f3431c1d6d7e920285f1e7382d4218d2d
staging/kmediaplayer/src/kfileaudiopreview/kfileaudiopreview.cpp
04efb249caca5639e3531b092681ce7fba0e8b05
29 matches
Mail list logo
