Re: KLocale plans (Re: KF5 Unit test results)

2012-11-04 Thread Chusslove Illich
> [: Chusslove Illich :] > While splitting out public methods dealing with translation from KLocale > [...] For completeness, also the overview of what I do with other methods (no comment needed except for objections :): All translateRaw*() methods are removed. They were used only by KLocalizedSt

Re: KLocale plans (Re: KF5 Unit test results)

2012-11-04 Thread Chusslove Illich
While splitting out public methods dealing with translation from KLocale, I got a doubt about localizedFilePath(). For a given file path, it returns the localized file path, if available, according to the same language list and fallback rules as for strings in PO files. Due to this, initially I tho

Re: KLocale plans (Re: KF5 Unit test results)

2012-10-27 Thread Chusslove Illich
> [: David Faure :] > Hi Chusslove, > > any progress? :-) No progress, but I'm going to do it right now. -- Chusslove Illich (Часлав Илић) signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-f

Re: KLocale plans (Re: KF5 Unit test results)

2012-10-24 Thread David Faure
On Sunday 16 September 2012 19:22:26 Chusslove Illich wrote: > > [: David Faure :] > > Anyhow, I recommend splitting "in place" (in kdecore), first, to have > > commits that do the splitting, separated from the commits that do the > > moving. I can even do the moving once you've done the API splitt

Re: KLocale plans (Re: KF5 Unit test results)

2012-09-16 Thread Chusslove Illich
> [: David Faure :] > Anyhow, I recommend splitting "in place" (in kdecore), first, to have > commits that do the splitting, separated from the commits that do the > moving. I can even do the moving once you've done the API splitting :-) Well that's totally great. I was thinking of asking about do

Re: KLocale plans (Re: KF5 Unit test results)

2012-09-16 Thread David Faure
On Saturday 15 September 2012 13:36:42 Chusslove Illich wrote: > > [: David Faure :] > > So either i18n is ported away from KLocale, or all that calendar stuff has > > to move into the ki18n framework, at least in the short term. > > Since including calendar stuff into ki18n would be a temporary m

Re: KLocale plans (Re: KF5 Unit test results)

2012-09-15 Thread Chusslove Illich
> [: David Faure :] > So either i18n is ported away from KLocale, or all that calendar stuff has > to move into the ki18n framework, at least in the short term. Since including calendar stuff into ki18n would be a temporary measure that would later have to be undone, I think it's best that I split

Re: KLocale plans (Re: KF5 Unit test results)

2012-09-13 Thread David Faure
On Tuesday 11 September 2012 13:15:37 Chusslove Illich wrote: > > [: David Faure :] > > Is it also part of your plans to remove i18n()'s dependency on KLocale? > > I consider it rather an orthogonal matter. I will anyway remove all Gettext- > related stuff from KLocale, before doing anything about

Re: KLocale plans (Re: KF5 Unit test results)

2012-09-11 Thread Chusslove Illich
> [: David Faure :] > Is it also part of your plans to remove i18n()'s dependency on KLocale? I consider it rather an orthogonal matter. I will anyway remove all Gettext- related stuff from KLocale, before doing anything about replacing *gettext() calls themselves. > This is what's blocking me no

KLocale plans (Re: KF5 Unit test results)

2012-09-10 Thread David Faure
On Wednesday 05 September 2012 10:48:54 Chusslove Illich wrote: > Next I plan to rewrite > klocalizedstring.h, such that it reflects the planned changes, but most > importantly to have more comprehensive doc appropriate for a standalone > component. After we review it, I go adapting the code. Water

Re: KF5 Unit test results

2012-09-07 Thread Chusslove Illich
> [: David Faure :] > Any objections if I remove the no-NLS code path? No objection from my side. (When I get to it, I'd even like to replace *gettext() calls with internal MO file handling, which is not that complicated. Then we can remove kludges in kcatalog.cpp, like rebinding catalog location

Re: KF5 Unit test results

2012-09-06 Thread David Faure
On Wednesday 05 September 2012 17:45:32 Chusslove Illich wrote: > >> [: Chusslove Illich :] > >> Now all work: Totals: 9 passed, 0 failed, 0 skipped. > > > > [: David Faure :] > > Damn it, so you won't be able to help me debug why it fails for me :( > > How about if you stick an i18n call into kd

Re: KF5 Unit test results

2012-09-05 Thread Chusslove Illich
>> [: Chusslove Illich :] >> Now all work: Totals: 9 passed, 0 failed, 0 skipped. > > [: David Faure :] > Damn it, so you won't be able to help me debug why it fails for me :( How about if you stick an i18n call into kde4-config (my favorite for this purpose :), maybe tests do something funny with

Re: KF5 Unit test results

2012-09-05 Thread David Faure
On Wednesday 05 September 2012 13:15:32 Chusslove Illich wrote: > >> [: Chusslove Illich :] > >> Totals: 7 passed, 3 failed, 0 skipped (where all 3 are due to > >> QCoreApplication::translate(), including 2 calls from testThreads()). > > > > [: David Faure :] > > Can you try again? I committed a f

Re: KF5 Unit test results

2012-09-05 Thread Chusslove Illich
>> [: Chusslove Illich :] >> Totals: 7 passed, 3 failed, 0 skipped (where all 3 are due to >> QCoreApplication::translate(), including 2 calls from testThreads()). > > [: David Faure :] > Can you try again? I committed a fix for the KDETranslator stuff. Now all work: Totals: 9 passed, 0 failed, 0

Re: KF5 Unit test results

2012-09-05 Thread David Faure
On Wednesday 05 September 2012 12:29:15 Chusslove Illich wrote: > > [: David Faure :] > > But back to translateToFrench(): could it be that it is skipped for lack > > of 'fr' translations on your system? > > That was the case just after I built anew :) But then I copied translations > into proper

Re: KF5 Unit test results

2012-09-05 Thread Chusslove Illich
> [: David Faure :] > But back to translateToFrench(): could it be that it is skipped for lack > of 'fr' translations on your system? That was the case just after I built anew :) But then I copied translations into proper place. So the final line of test output now is Totals: 7 passed, 3 failed, 0

Re: KF5 Unit test results

2012-09-05 Thread David Faure
On Wednesday 05 September 2012 10:48:54 Chusslove Illich wrote: > > [: David Faure :] > > Could you have another lock? It's broken again, and this time it's not due > > to catalogLocaleDir(), I checked it in kdelibs-4 and kf5, and it returns / > > usr/share/locale in both (with trailing slash in kd

Re: KF5 Unit test results

2012-09-05 Thread Chusslove Illich
> [: David Faure :] > Could you have another lock? It's broken again, and this time it's not due > to catalogLocaleDir(), I checked it in kdelibs-4 and kf5, and it returns / > usr/share/locale in both (with trailing slash in kdelibs-4, but adding one > didn't help). > [...] > Thanks for your help,

Re: KF5 Unit test results

2012-09-03 Thread David Faure
On Friday 10 August 2012 14:19:17 Chusslove Illich wrote: > > [: David Faure :] > > 5 - kdecore-klocalizedstringtest (Failed) // I don't get it. > > dgettext("kdelibs4", msgid) works in kdelibs-4.9 and not here > I've fixed this now. Could you have another lock? It's broken again, and this tim

Re: KF5 Unit test results

2012-08-20 Thread David Faure
On Sunday 19 August 2012 14:59:29 Rolf Eike Beer wrote: > David Faure wrote: > > Update: > > > > * kdelibs-frameworks with Qt4: > > > > 100% tests passed, 0 tests failed out of 126 > > > > (I fixed the plasma tests) > > > > * kdelibs-frameworks with Qt5: > > > > The following tests FAILED: > >

Re: KF5 Unit test results

2012-08-19 Thread Rolf Eike Beer
David Faure wrote: > Update: > > * kdelibs-frameworks with Qt4: > > 100% tests passed, 0 tests failed out of 126 > > (I fixed the plasma tests) > > * kdelibs-frameworks with Qt5: > > The following tests FAILED: > 108 - httpheaderdispositiontest (Failed) [**] > > [**] > FAIL! : HeaderDispositionTes

Re: KF5 Unit test results

2012-08-19 Thread David Faure
Update: * kdelibs-frameworks with Qt4: 100% tests passed, 0 tests failed out of 126 (I fixed the plasma tests) * kdelibs-frameworks with Qt5: The following tests FAILED: 12 - kdecore-kdatetimetest (Failed) -- John, help! 25 - kdecore-kcalendartest (Failed) -- John, help!

Re: KF5 Unit test results

2012-08-10 Thread David Faure
New baseline for Qt4-based builds: All tests pass, except for the 3 plasma ones, for lack of any interested plasma hacker. If you see any different result, check your setup, check why individual tests fail, and if you still can't figure it out, post test output here. -- David Faure, fa...@kde

Re: KF5 Unit test results

2012-08-10 Thread David Faure
On Friday 10 August 2012 14:19:17 Chusslove Illich wrote: > > [: David Faure :] > > 5 - kdecore-klocalizedstringtest (Failed) // I don't get it. > > dgettext("kdelibs4", msgid) works in kdelibs-4.9 and not here > I've fixed this now. Thanks Chusslove, you rock! -- David Faure, fa...@kde.org,

Re: KF5 Unit test results

2012-08-10 Thread Chusslove Illich
> [: Chusslove Illich :] > translateQt fails (for me?), I didn't touch anything about that. False alarm, forgot to install kdeqt.po. -- Chusslove Illich (Часлав Илић) signature.asc Description: This is a digitally signed message part. ___ Kde-framewo

Re: KF5 Unit test results

2012-08-10 Thread Chusslove Illich
> [: David Faure :] > 5 - kdecore-klocalizedstringtest (Failed) // I don't get it. > dgettext("kdelibs4", msgid) works in kdelibs-4.9 and not here I've fixed this now. translateQt fails (for me?), I didn't touch anything about that. -- Chusslove Illich (Часлав Илић) signature.asc Descrip

Re: KF5 Unit test results

2012-08-06 Thread David Faure
On Sunday 29 July 2012 14:53:47 David Faure wrote: > 71 - kdeui-kstartupinfo_unittest (Failed) // hangs. > KXMessages::x11Event needs porting to XCB Fixed. > 76 - kdeui-ktoolbar_unittest (Failed) // something about the keyboard > modifiers > in triggered(Qt::MouseButtons,Qt::Keybo

KF5 Unit test results

2012-07-29 Thread David Faure
I just fixed a number of test failures, but a few remain: * With qt4: The following tests FAILED: 5 - kdecore-klocalizedstringtest (Failed) // I don't get it. dgettext("kdelibs4", msgid) works in kdelibs-4.9 and not here 39 - kwidgets-kglobalsettingstest (Failed) // OK