Re: KDirWatch issue

2017-05-14 Thread David Faure
On dimanche 14 mai 2017 19:46:16 CEST Albert Astals Cid wrote: > Should we simply mark stopDirScan as deprecated and make it call > removeDir? Ah, yes, that's an option. Overall it will make things faster compared to unwanted notifications indeed. https://phabricator.kde.org/D5856 seems to work.

Re: KDirWatch issue

2017-05-14 Thread Albert Astals Cid
El dissabte, 13 de maig de 2017, a les 14:00:15 CEST, David Faure va escriure: > On lundi 8 mai 2017 17:51:06 CEST Albert Astals Cid wrote: > > El dilluns, 8 de maig de 2017, a les 17:32:35 CEST, David Faure va escriure: > > > On lundi 8 mai 2017 16:14:47 CEST Albert Astals Cid wrote: > > > > > I

Re: KDirWatch issue

2017-05-13 Thread David Faure
On lundi 8 mai 2017 17:51:06 CEST Albert Astals Cid wrote: > El dilluns, 8 de maig de 2017, a les 17:32:35 CEST, David Faure va escriure: > > On lundi 8 mai 2017 16:14:47 CEST Albert Astals Cid wrote: > > > > I think the point is that we *want* the notification to happen after > > > > restartDirSca

Re: KDirWatch issue

2017-05-08 Thread Albert Astals Cid
El dilluns, 8 de maig de 2017, a les 17:32:35 CEST, David Faure va escriure: > On lundi 8 mai 2017 16:14:47 CEST Albert Astals Cid wrote: > > > I think the point is that we *want* the notification to happen after > > > restartDirScan, in the cases where stopDirScan/restartDirScan is used. > > > >

Re: KDirWatch issue

2017-05-08 Thread David Faure
On lundi 8 mai 2017 16:14:47 CEST Albert Astals Cid wrote: > > I think the point is that we *want* the notification to happen after > > restartDirScan, in the cases where stopDirScan/restartDirScan is used. > > No, we actually have a test that proves that we get to signal after > restartDirScan is

Re: KDirWatch issue

2017-05-08 Thread Albert Astals Cid
El dissabte, 6 de maig de 2017, a les 10:44:42 CEST, David Faure va escriure: > On mercredi 3 mai 2017 12:05:47 CEST Albert Astals Cid wrote: > > El dimecres, 3 de maig de 2017, a les 11:53:02 CEST, Albert Astals Cid va > > > > escriure: > > > El dilluns, 24 d’abril de 2017, a les 20:08:26 CEST, M

Re: KDirWatch issue

2017-05-06 Thread David Faure
On mercredi 3 mai 2017 12:05:47 CEST Albert Astals Cid wrote: > El dimecres, 3 de maig de 2017, a les 11:53:02 CEST, Albert Astals Cid va > > escriure: > > El dilluns, 24 d’abril de 2017, a les 20:08:26 CEST, Martin Koller va > > > > escriure: > > > Hi, > > > > > > just wondering if I'm doing so

Re: KDirWatch issue

2017-05-03 Thread Albert Astals Cid
El dimecres, 3 de maig de 2017, a les 11:53:02 CEST, Albert Astals Cid va escriure: > El dilluns, 24 d’abril de 2017, a les 20:08:26 CEST, Martin Koller va > > escriure: > > Hi, > > > > just wondering if I'm doing something wrong or there really is a bug in > > KDirWatch (I'm on openSuse Leap 42

Re: KDirWatch issue

2017-05-03 Thread Albert Astals Cid
El dilluns, 24 d’abril de 2017, a les 20:08:26 CEST, Martin Koller va escriure: > Hi, > > just wondering if I'm doing something wrong or there really is a bug in > KDirWatch (I'm on openSuse Leap 42.2, KF5 5.33.0) > > From the docs I understand that when I call > > KDirWatch::stopDirScan(dir);

KDirWatch issue

2017-04-25 Thread Martin Koller
Hi, just wondering if I'm doing something wrong or there really is a bug in KDirWatch (I'm on openSuse Leap 42.2, KF5 5.33.0) From the docs I understand that when I call KDirWatch::stopDirScan(dir); ... create files in the dir ... KDirWatch::restartDirScan(dir) it should not emit the dirty si